Review Request 33752: MESOS-2537: Fix AC_ARG_ENABLED option processing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33752/ --- Review request for mesos and Cody Maloney. Bugs: MESOS-2537 https://issues.

Re: Review Request 33752: MESOS-2537: Fix AC_ARG_ENABLED option processing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33752/#review82253 --- Patch looks great! Reviews applied: [33752] All tests passed. - M

Re: Review Request 33752: MESOS-2537: Fix AC_ARG_ENABLED option processing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33752/#review82272 --- Overall looks good to me. Should have Tim St. Clair [~tstclair] revi

Re: Review Request 33752: MESOS-2537: Fix AC_ARG_ENABLED option processing

> On May 1, 2015, 7:30 p.m., Cody Maloney wrote: > > configure.ac, line 1407 > > > > > > I worry this changes the behavior some when --disable-bundled is set > > (Previously it seems like it would see if it could fin

Re: Review Request 33752: MESOS-2537: Fix AC_ARG_ENABLED option processing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33752/ --- (Updated June 4, 2015, 7:31 p.m.) Review request for mesos, Cody Maloney and Ti

Re: Review Request 33752: MESOS-2537: Fix AC_ARG_ENABLED option processing

> On May 1, 2015, 7:30 p.m., Cody Maloney wrote: > > configure.ac, line 1407 > > > > > > I worry this changes the behavior some when --disable-bundled is set > > (Previously it seems like it would see if it could fin

Re: Review Request 33752: MESOS-2537: Fix AC_ARG_ENABLED option processing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33752/#review86738 --- LGTM - Cody Maloney On June 4, 2015, 7:31 p.m., James Peach wrote

Re: Review Request 33752: MESOS-2537: Fix AC_ARG_ENABLED option processing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33752/ --- (Updated June 9, 2015, 12:02 a.m.) Review request for mesos, Cody Maloney and T

Re: Review Request 33752: MESOS-2537: Fix AC_ARG_ENABLED option processing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33752/ --- (Updated Aug. 24, 2015, 9:54 p.m.) Review request for mesos, Cody Maloney and T

Re: Review Request 33752: MESOS-2537: Fix AC_ARG_ENABLED option processing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33752/ --- (Updated Aug. 26, 2015, 8:11 p.m.) Review request for mesos, Cody Maloney and T

Re: Review Request 33752: MESOS-2537: Fix AC_ARG_ENABLED option processing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33752/#review96588 --- configure.ac (line 145)

Re: Review Request 33752: MESOS-2537: Fix AC_ARG_ENABLED option processing

> On Aug. 26, 2015, 9:01 p.m., Timothy St. Clair wrote: > > Have you tested all combinations here? - Timothy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33752/#review96588 ---

Re: Review Request 33752: MESOS-2537: Fix AC_ARG_ENABLED option processing

> On Aug. 26, 2015, 9:01 p.m., Timothy St. Clair wrote: > > > > Timothy St. Clair wrote: > Have you tested all combinations here? No, only some of the possible combinations. The addition of buld flags output makes is easier to tell when it it doing the right thing. This change doesn't rea

Re: Review Request 33752: MESOS-2537: Fix AC_ARG_ENABLED option processing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33752/#review153528 --- It would be great to get MESOS-2537 fixed, would you consider brin

Re: Review Request 33752: MESOS-2537: Fix AC_ARG_ENABLED option processing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33752/#review141480 --- Closing this review due to inactivity. Please see our [guidelines