Re: Review Request 34308: Filter revocable resources.

2015-05-21 Thread Vinod Kone
> On May 20, 2015, 12:34 a.m., Vinod Kone wrote: > > Ship It! I'll commit this for you, as I need this patch. - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34308/#review84426 --

Re: Review Request 34308: Filter revocable resources.

2015-05-19 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34308/#review84426 --- Ship it! Ship It! - Vinod Kone On May 20, 2015, 12:29 a.m., Ian

Re: Review Request 34308: Filter revocable resources.

2015-05-19 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34308/ --- (Updated May 19, 2015, 5:29 p.m.) Review request for mesos and Vinod Kone. Ch

Re: Review Request 34308: Filter revocable resources.

2015-05-19 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34308/#review84357 --- LGTM, modulo test, as Nik suggested. - Vinod Kone On May 18, 2015

Re: Review Request 34308: Filter revocable resources.

2015-05-19 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34308/#review84329 --- LGTM - want to add a test in src/tests/resources_tests.cpp too? - N

Re: Review Request 34308: Filter revocable resources.

2015-05-18 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34308/ --- (Updated May 18, 2015, 1:49 p.m.) Review request for mesos and Vinod Kone. Ch

Review Request 34308: Filter revocable resources.

2015-05-15 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34308/ --- Review request for mesos and Vinod Kone. Repository: mesos Description --