Review Request 34894: Add new message for Traffic Control statistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34894/ --- Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. Reposit

Re: Review Request 34894: Add new message for Traffic Control statistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34894/#review86013 --- Patch looks great! Reviews applied: [34830, 34832, 34426, 34863, 34

Re: Review Request 34894: Add new message for Traffic Control statistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34894/#review86033 --- include/mesos/mesos.proto

Re: Review Request 34894: Add new message for Traffic Control statistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34894/#review86042 --- include/mesos/mesos.proto

Re: Review Request 34894: Add new message for Traffic Control statistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34894/#review86048 --- include/mesos/mesos.proto

Re: Review Request 34894: Add new message for Traffic Control statistics

> On June 1, 2015, 7:17 p.m., Ian Downes wrote: > > include/mesos/mesos.proto, lines 543-545 > > > > > > What's possible here: can more than one be present or is it only any > > one? What's the difference between thes

Re: Review Request 34894: Add new message for Traffic Control statistics

> On June 1, 2015, 6:32 p.m., Chi Zhang wrote: > > include/mesos/mesos.proto, lines 543-545 > > > > > > Maybe some comments for the three names? (kinda the reason you are not > > using 'repeated' of TrafficControlStat

Re: Review Request 34894: Add new message for Traffic Control statistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34894/ --- (Updated June 2, 2015, 8:52 p.m.) Review request for mesos, Chi Zhang, Ian Down

Re: Review Request 34894: Add new message for Traffic Control statistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34894/#review86287 --- Bad patch! Reviews applied: [34899, 34830, 34832, 34426] Failed co

Re: Review Request 34894: Add new message for Traffic Control statistics

> On June 1, 2015, 7:17 p.m., Ian Downes wrote: > > include/mesos/mesos.proto, line 529 > > > > > > This page doesn't seem to document these statistics. Is there a more > > relevant page? Only slightly more relevant

Re: Review Request 34894: Add new message for Traffic Control statistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34894/ --- (Updated June 3, 2015, 9:54 p.m.) Review request for mesos, Chi Zhang, Ian Down

Re: Review Request 34894: Add new message for Traffic Control statistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34894/#review86503 --- Patch looks great! Reviews applied: [34894] All tests passed. - M

Re: Review Request 34894: Add new message for Traffic Control statistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34894/#review86860 --- Ship it! LGTM. I'll wait for Ian's shipit. - Jie Yu On June 3, 2

Re: Review Request 34894: Add new message for Traffic Control statistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34894/#review86875 --- Much cleaner! Just a question about enumerating the ids/types. inc

Re: Review Request 34894: Add new message for Traffic Control statistics

> On June 6, 2015, 12:10 a.m., Ian Downes wrote: > > include/mesos/mesos.proto, line 533 > > > > > > What's the set of possible ids? If it's the well-defined set that we > > discussed offline then we should probably e

Re: Review Request 34894: Add new message for Traffic Control statistics

> On June 6, 2015, 12:10 a.m., Ian Downes wrote: > > include/mesos/mesos.proto, line 533 > > > > > > What's the set of possible ids? If it's the well-defined set that we > > discussed offline then we should probably e

Re: Review Request 34894: Add new message for Traffic Control statistics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34894/#review87062 --- Ship it! Ship It! - Ian Downes On June 3, 2015, 2:54 p.m., Paul