Re: Review Request 35635: Formatting cleanup in the Slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35635/#review88571 --- Ship it! Ship It! - Benjamin Hindman On June 19, 2015, 12:39 p.m

Re: Review Request 35635: Formatting cleanup in the Slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35635/ --- (Updated June 19, 2015, 12:39 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 35635: Formatting cleanup in the Slave.

> On June 19, 2015, 9:17 a.m., Alexander Rukletsov wrote: > > Is it manual clean-up or you have fed the file to clang-format? It was a mix of both. The function calls that fit in one line for example, I just stroked `Ctrl-K` to see if it fit, rather than trying it out manually. The incorrect i

Re: Review Request 35635: Formatting cleanup in the Slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35635/ --- (Updated June 19, 2015, 12:11 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 35635: Formatting cleanup in the Slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35635/#review88510 --- Ship it! Is it manual clean-up or you have fed the file to clang-fo

Re: Review Request 35635: Formatting cleanup in the Slave.

> On June 19, 2015, 12:40 a.m., Ben Mahler wrote: > > src/slave/slave.cpp, lines 3154-3159 > > > > > > Is this really better? Also we have a lot of code following this old > > style, I'm hesitant to introduce inconsi

Re: Review Request 35635: Formatting cleanup in the Slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35635/ --- (Updated June 19, 2015, 2:12 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 35635: Formatting cleanup in the Slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35635/#review88475 --- src/slave/slave.cpp (lines 2904 - 2905)

Re: Review Request 35635: Formatting cleanup in the Slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35635/#review88474 --- The following are the list of incorrect styles that were fixed in th

Review Request 35635: Formatting cleanup in the Slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35635/ --- Review request for mesos, Benjamin Hindman and Till Toenshoff. Repository: meso