Re: Review Request 35638: Removed const-ref to temporaries from the Slave.

2015-06-19 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35638/ --- (Updated June 19, 2015, 7:12 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 35638: Removed const-ref to temporaries from the Slave.

2015-06-19 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35638/#review88573 --- Ship it! Ship It! - Benjamin Hindman On June 19, 2015, 11:53 a.m

Re: Review Request 35638: Removed const-ref to temporaries from the Slave.

2015-06-19 Thread Alexander Rukletsov
> On June 19, 2015, 9:26 a.m., Alexander Rukletsov wrote: > > src/slave/slave.cpp, line 1280 > > > > > > Though currently we guarantee `executorInfo` lifetime is not shorter > > than `executorId`'s, I think we agreed

Re: Review Request 35638: Removed const-ref to temporaries from the Slave.

2015-06-19 Thread Michael Park
> On June 19, 2015, 9:26 a.m., Alexander Rukletsov wrote: > > I think MESOS-2632 would be more appropriate. Fixed. > On June 19, 2015, 9:26 a.m., Alexander Rukletsov wrote: > > src/slave/slave.cpp, line 1280 > > > > >

Re: Review Request 35638: Removed const-ref to temporaries from the Slave.

2015-06-19 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35638/ --- (Updated June 19, 2015, 11:53 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 35638: Removed const-ref to temporaries from the Slave.

2015-06-19 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35638/#review88511 --- I think MESOS-2632 would be more appropriate. src/slave/slave.cpp

Re: Review Request 35638: Removed const-ref to temporaries from the Slave.

2015-06-18 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35638/ --- (Updated June 19, 2015, 12:43 a.m.) Review request for mesos, Benjamin Hindman,

Review Request 35638: Removed const-ref to temporaries from the Slave.

2015-06-18 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35638/ --- Review request for mesos, Benjamin Hindman, Jie Yu, and Joris Van Remoortere. R