Re: Review Request 35755: Changed fetcher to handle leading whitespace in URLs.

2015-07-18 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35755/#review92188 --- Ship it! I'll take care of these minor issues and commit, thanks.

Re: Review Request 35755: Changed fetcher to handle leading whitespace in URLs.

2015-07-09 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35755/ --- (Updated July 9, 2015, 10:19 p.m.) Review request for mesos and Joris Van Remoo

Re: Review Request 35755: Changed fetcher to handle leading whitespace in URLs.

2015-07-06 Thread Artem Harutyunyan
> On July 5, 2015, 8:02 p.m., Benjamin Hindman wrote: > > > > Joris Van Remoortere wrote: > Hey Ben, > Great questions in the latter half of your review. > It turns out that the original test was malformed. It happened to pass > because there is also a help process that responds to

Re: Review Request 35755: Changed fetcher to handle leading whitespace in URLs.

2015-07-06 Thread Joris Van Remoortere
> On July 6, 2015, 3:02 a.m., Benjamin Hindman wrote: > > Hey Ben, Great questions in the latter half of your review. It turns out that the original test was malformed. It happened to pass because there is also a help process that responds to the `/help` endpoint. The original intent of the tes

Re: Review Request 35755: Changed fetcher to handle leading whitespace in URLs.

2015-07-06 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35755/ --- (Updated July 6, 2015, 9:03 a.m.) Review request for mesos and Joris Van Remoor

Re: Review Request 35755: Changed fetcher to handle leading whitespace in URLs.

2015-07-05 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35755/#review90423 --- src/launcher/fetcher.cpp (line 160)

Re: Review Request 35755: Changed fetcher to handle leading whitespace in URLs.

2015-06-30 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35755/ --- (Updated June 30, 2015, 4:24 p.m.) Review request for mesos and Joris Van Remoo