Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36321/#review97133 --- include/mesos/mesos.proto (lines 140 - 154)

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

> On Aug. 31, 2015, 1:06 p.m., Ben Mahler wrote: > > include/mesos/mesos.proto, lines 140-154 > > > > > > Should this have been: > > > > ``` > > message Interval { > > required TimeInfo start; >

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36321/#review96866 --- include/mesos/mesos.proto (line 876)

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

On Aug. 27, 2015, 1:06 p.m., Benjamin Hindman wrote: include/mesos/mesos.proto, lines 926-927 https://reviews.apache.org/r/36321/diff/13/?file=1053309#file1053309line926 Why do we need the URL? Can we comment for folks so they know what they might need/use this for? Added some

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

On Aug. 28, 2015, 7:49 a.m., Joris Van Remoortere wrote: include/mesos/mesos.proto, line 877 https://reviews.apache.org/r/36321/diff/13-14/?file=1053309#file1053309line877 In your last diff, you changed a bunch of `window` to `interval`. Do you want to change this one as well? If

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36321/#review96743 --- Ship it! include/mesos/mesos.proto (lines 926 - 927)

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36321/ --- (Updated Aug. 27, 2015, 3:46 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36321/#review96508 --- Ship it! Ship It! - Guangya Liu On Aug. 25, 2015, 10:53 p.m.,

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36321/#review96366 --- include/mesos/mesos.proto (line 914)

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

On Aug. 24, 2015, 5:57 p.m., Guangya Liu wrote: include/mesos/mesos.proto, line 939 https://reviews.apache.org/r/36321/diff/10/?file=1048529#file1048529line939 Can you please elaborate more for why in maintaince purpose, this field is always empty? Why cannot an operator set the

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36321/ --- (Updated Aug. 25, 2015, 8:24 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36321/#review96126 --- include/mesos/mesos.proto (line 123)

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

On Aug. 21, 2015, 6:35 p.m., Alexander Rukletsov wrote: include/mesos/mesos.proto, lines 917-920 https://reviews.apache.org/r/36321/diff/9/?file=1038857#file1038857line917 I think the name `Unavailability` is too specific to maintenance, how about something more generic, like

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

On Aug. 25, 2015, 9:55 p.m., Alexander Rukletsov wrote: include/mesos/mesos.proto, lines 847-850 https://reviews.apache.org/r/36321/diff/9/?file=1038857#file1038857line847 As per my comment for `InverseOffers`, let's clarify the contract and guarantees here. Or, as I said

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36321/ --- (Updated Aug. 25, 2015, 3:53 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

On Aug. 25, 2015, 2:55 p.m., Alexander Rukletsov wrote: include/mesos/mesos.proto, line 129 https://reviews.apache.org/r/36321/diff/9/?file=1038857#file1038857line129 For consistency, please one space between sentences! Here and below. The codebase isn't consistent in this respect.

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

On Aug. 25, 2015, 10:21 a.m., Guangya Liu wrote: include/mesos/mesos.proto, line 939 https://reviews.apache.org/r/36321/diff/10/?file=1048529#file1048529line939 Thanks Joe! Got it, but I think that it is better that we can add some notes here to be more clear Next time, please

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36321/ --- (Updated Aug. 24, 2015, 11:26 a.m.) Review request for mesos, Benjamin

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

On Aug. 21, 2015, 11:35 a.m., Alexander Rukletsov wrote: include/mesos/mesos.proto, lines 917-920 https://reviews.apache.org/r/36321/diff/9/?file=1038857#file1038857line917 I think the name `Unavailability` is too specific to maintenance, how about something more generic, like

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36321/#review96259 --- include/mesos/mesos.proto (line 125)

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

On Aug. 21, 2015, 6:35 p.m., Alexander Rukletsov wrote: include/mesos/mesos.proto, lines 917-920 https://reviews.apache.org/r/36321/diff/9/?file=1038857#file1038857line917 I think the name `Unavailability` is too specific to maintenance, how about something more generic, like

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36321/#review96073 --- include/mesos/mesos.proto (lines 917 - 920)

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

On Aug. 21, 2015, 11:35 a.m., Alexander Rukletsov wrote: include/mesos/mesos.proto, lines 917-920 https://reviews.apache.org/r/36321/diff/9/?file=1038857#file1038857line917 I think the name `Unavailability` is too specific to maintenance, how about something more generic, like

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36321/ --- (Updated Aug. 12, 2015, 3:07 p.m.) Review request for mesos, Benjamin Hindman,