Re: Review Request 36424: Created a command executor helper method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36424/ --- (Updated July 14, 2015, 4:21 a.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 36424: Created a command executor helper method.

> On July 13, 2015, 5:20 p.m., Paul Brett wrote: > > is inline really necessary here? > On July 13, 2015, 5:20 p.m., Paul Brett wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, line 307 > > > > > >

Re: Review Request 36424: Created a command executor helper method.

> On July 14, 2015, 12:20 a.m., Paul Brett wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, line 307 > > > > > > How about returning a tuple/struct of stdout, stderr and return code > > and let the cal

Re: Review Request 36424: Created a command executor helper method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36424/#review92028 --- >From an email thread >[here](http://www.mail-archive.com/dev@mesos

Re: Review Request 36424: Created a command executor helper method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36424/ --- (Updated July 17, 2015, 5:52 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36424: Created a command executor helper method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36424/#review92038 --- 3rdparty/libprocess/include/process/subprocess.hpp (lines 302 - 304

Re: Review Request 36424: Created a command executor helper method.

> On July 17, 2015, 8:48 a.m., Alexander Rojas wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, lines 302-304 > > > > > > You may ignore this, but I'm not sure if ignoring `cerr` when the > > command s

Re: Review Request 36424: Created a command executor helper method.

> On July 14, 2015, 12:20 a.m., Paul Brett wrote: > > > > Artem Harutyunyan wrote: > is inline really necessary here? well, it is - as this is a header file (not having the `inline` will cause a linker error for a 'duplicate definition' or something). Happy to move it to a `.cpp` file, bu

Re: Review Request 36424: Created a command executor helper method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36424/ --- (Updated July 18, 2015, 1:55 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36424: Created a command executor helper method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36424/ --- (Updated July 18, 2015, 2 a.m.) Review request for mesos, Benjamin Hindman, Ben

Re: Review Request 36424: Created a command executor helper method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36424/#review92232 --- 3rdparty/libprocess/include/process/subprocess.hpp (line 364)

Re: Review Request 36424: Created a command executor helper method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36424/ --- (Updated July 22, 2015, 5:49 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36424: Created a command executor helper method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36424/ --- (Updated July 22, 2015, 6:20 a.m.) Review request for mesos, Benjamin Hindman,