Re: Review Request 36440: Enabled docker volume support for DockerContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36440/ --- (Updated 六月 16, 2016, 11:23 p.m.) Review request for mesos, Gilbert Song and Ji

Re: Review Request 36440: Enabled docker volume support for DockerContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36440/#review138072 --- Can you rebase. The patch does not apply. - Jie Yu On June 15,

Re: Review Request 36440: Enabled docker volume support for DockerContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36440/#review138062 --- Ship it! Ship It! - Jie Yu On June 15, 2016, 11:02 p.m., Gua

Re: Review Request 36440: Enabled docker volume support for DockerContainerizer.

> On 六月 15, 2016, 11:05 p.m., Guangya Liu wrote: > > src/docker/docker.cpp, line 524 > > > > > > I think that we should also remove this checking here as `mode` is > > required, comments? Posted a patch here https:

Re: Review Request 36440: Enabled docker volume support for DockerContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36440/#review137878 --- src/docker/docker.cpp (line 524)

Re: Review Request 36440: Enabled docker volume support for DockerContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36440/ --- (Updated 六月 15, 2016, 11:02 p.m.) Review request for mesos, Gilbert Song and Ji

Re: Review Request 36440: Enabled docker volume support for DockerContainerizer.

> On June 12, 2016, 7:10 p.m., Jie Yu wrote: > > src/docker/docker.cpp, lines 559-562 > > > > > > I don't get this check. if we end up here, has_host_path() is false and > > has_source() is false, why we bother havi

Re: Review Request 36440: Enabled docker volume support for DockerContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36440/#review137481 --- Patch looks great! Reviews applied: [45377, 36440] Passed comman

Re: Review Request 36440: Enabled docker volume support for DockerContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36440/ --- (Updated 六月 14, 2016, 9:49 a.m.) Review request for mesos, Gilbert Song and Jie

Re: Review Request 36440: Enabled docker volume support for DockerContainerizer.

> On 六月 14, 2016, 8:42 a.m., Gilbert Song wrote: > > src/docker/docker.cpp, line 548 > > > > > > This will segfault if no driver specified, right? > > > > I roughly remember docker supports volume by using d

Re: Review Request 36440: Enabled docker volume support for DockerContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36440/#review137466 --- src/docker/docker.cpp (line 548)

Re: Review Request 36440: Enabled docker volume support for DockerContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36440/#review137231 --- Patch looks great! Reviews applied: [45377, 36440] Passed comman

Re: Review Request 36440: Enabled docker volume support for DockerContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36440/ --- (Updated 六月 13, 2016, 4:36 a.m.) Review request for mesos, Gilbert Song and Jie

Re: Review Request 36440: Enabled docker volume support for DockerContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36440/ --- (Updated 六月 13, 2016, 3:43 a.m.) Review request for mesos, Gilbert Song and Jie

Re: Review Request 36440: Enabled docker volume support for DockerContainerizer.

> On 六月 12, 2016, 7:10 p.m., Jie Yu wrote: > > src/docker/docker.cpp, lines 559-562 > > > > > > I don't get this check. if we end up here, has_host_path() is false and > > has_source() is false, why we bother having

Re: Review Request 36440: Enabled docker volume support for DockerContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36440/#review137198 --- include/mesos/mesos.proto (lines 1781 - 1783)

Re: Review Request 36440: Enabled docker volume support for DockerContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36440/#review132371 --- Patch looks great! Reviews applied: [45377, 36440] Passed comman

Re: Review Request 36440: Enabled docker volume support for DockerContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36440/ --- (Updated 五月 10, 2016, 3:50 a.m.) Review request for mesos, Gilbert Song and Jie

Re: Review Request 36440: Enabled docker volume support for DockerContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36440/ --- (Updated May 10, 2016, 3:03 a.m.) Review request for mesos, Gilbert Song and Ji

Re: Review Request 36440: Enabled docker volume support for DockerContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36440/#review132210 --- Patch looks great! Reviews applied: [36440] Passed command: expo

Re: Review Request 36440: Enabled docker volume support for DockerContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36440/ --- (Updated May 9, 2016, 5:25 a.m.) Review request for mesos, Gilbert Song and Jie