Review Request 36586: Updated scheduler driver to send SUBSCRIBE call.

2015-07-17 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36586/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-3055 https://issues.ap

Re: Review Request 36586: Updated scheduler driver to send SUBSCRIBE call.

2015-07-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36586/#review92134 --- Bad patch! Reviews applied: [36586] Failed command: ./support/appl

Re: Review Request 36586: Updated scheduler driver to send SUBSCRIBE call.

2015-07-17 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36586/ --- (Updated July 17, 2015, 11:08 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 36586: Updated scheduler driver to send SUBSCRIBE call.

2015-07-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36586/#review92144 --- Patch looks great! Reviews applied: [36586] All tests passed. - M

Re: Review Request 36586: Updated scheduler driver to send SUBSCRIBE call.

2015-07-20 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36586/#review92326 --- Ship it! Looks good, just a question around whether we want to be t

Re: Review Request 36586: Updated scheduler driver to send SUBSCRIBE call.

2015-07-22 Thread Vinod Kone
> On July 20, 2015, 9:46 p.m., Ben Mahler wrote: > > src/tests/rate_limiting_tests.cpp, lines 134-136 > > > > > > Note that in these tests, we've lost the fact that some of these > > subscribe calls should not have

Re: Review Request 36586: Updated scheduler driver to send SUBSCRIBE call.

2015-07-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36586/ --- (Updated July 22, 2015, 6:11 p.m.) Review request for mesos and Ben Mahler. C