Re: Review Request 36946: Factored out the pattern for URL generation in a fetcher test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36946/#review93878 --- Ship it! Ship It! - Bernd Mathiske On July 31, 2015, 8:23 a.m.,

Re: Review Request 36946: Factored out the pattern for URL generation in a fetcher test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36946/#review93733 --- Patch looks great! Reviews applied: [36946] All tests passed. - M

Re: Review Request 36946: Factored out the pattern for URL generation in a fetcher test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36946/#review93728 --- Ship it! Ship It! - haosdent huang On July 31, 2015, 3:23 p.m.,

Re: Review Request 36946: Factored out the pattern for URL generation in a fetcher test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36946/ --- (Updated July 31, 2015, 8:23 a.m.) Review request for mesos, Bernd Mathiske and

Re: Review Request 36946: Factored out the pattern for URL generation in a fetcher test.

> On July 31, 2015, 12:39 a.m., Bernd Mathiske wrote: > > src/tests/fetcher_tests.cpp, line 343 > > > > > > This change seems to eliminate the essence of the test, namely the > > leading white space. > > Klaus Ma w

Re: Review Request 36946: Factored out the pattern for URL generation in a fetcher test.

> On July 31, 2015, 7:39 a.m., Bernd Mathiske wrote: > > src/tests/fetcher_tests.cpp, line 343 > > > > > > This change seems to eliminate the essence of the test, namely the > > leading white space. There are two U

Re: Review Request 36946: Factored out the pattern for URL generation in a fetcher test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36946/#review93704 --- src/tests/fetcher_tests.cpp (line 343)

Re: Review Request 36946: Factored out the pattern for URL generation in a fetcher test.

> On July 30, 2015, 5:14 p.m., haosdent huang wrote: > > src/tests/fetcher_tests.cpp, line 332 > > > > > > ``` > > // Tests whether fetcher can process URIs that contain leading > > whitespace > > ``` > >

Re: Review Request 36946: Factored out the pattern for URL generation in a fetcher test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36946/#review93607 --- Patch looks great! Reviews applied: [36946] All tests passed. - M

Re: Review Request 36946: Factored out the pattern for URL generation in a fetcher test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36946/#review93605 --- src/tests/fetcher_tests.cpp (line 332)

Review Request 36946: Factored out the pattern for URL generation in a fetcher test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36946/ --- Review request for mesos, Bernd Mathiske and Klaus Ma. Bugs: MESOS-3023 htt