Re: Review Request 37032: Extend permissions.hpp to work on both Windows and POSIX.

2015-09-10 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37032/ --- (Updated Sept. 10, 2015, 7:36 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37032: Extend permissions.hpp to work on both Windows and POSIX.

2015-09-10 Thread Alex Clemmer
> On Sept. 8, 2015, 11:04 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp, lines 140-143 > > > > > > I don't think it's obvious from reading this the first time that

Re: Review Request 37032: Extend permissions.hpp to work on both Windows and POSIX.

2015-09-10 Thread Joseph Wu
> On Sept. 8, 2015, 3:51 p.m., Artem Harutyunyan wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp, lines 152-159 > > > > > > Do we really need to leave this up to the user to decide? What's the

Re: Review Request 37032: Extend permissions.hpp to work on both Windows and POSIX.

2015-09-10 Thread Artem Harutyunyan
> On Sept. 8, 2015, 3:51 p.m., Artem Harutyunyan wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/permissions.hpp, line 57 > > > > > > A comment describing why do we need this function would be great. >

Re: Review Request 37032: Extend permissions.hpp to work on both Windows and POSIX.

2015-09-10 Thread Joris Van Remoortere
> On Sept. 8, 2015, 10:51 p.m., Artem Harutyunyan wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp, lines 152-159 > > > > > > Do we really need to leave this up to the user to decide? What's th

Re: Review Request 37032: Extend permissions.hpp to work on both Windows and POSIX.

2015-09-10 Thread Artem Harutyunyan
> On Sept. 8, 2015, 3:51 p.m., Artem Harutyunyan wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp, lines 152-159 > > > > > > Do we really need to leave this up to the user to decide? What's the