Review Request 37114: MESOS-3187, support docker host command line option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/ --- Review request for mesos. Bugs: MESOS-3187 https://issues.apache.org/jira/b

Re: Review Request 37114: MESOS-3187, support docker host command line option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/ --- (Updated Aug. 6, 2015, 9:03 p.m.) Review request for mesos. Bugs: MESOS-3187

Re: Review Request 37114: MESOS-3187, support docker host command line option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/#review94472 --- We already have a flag called docker_socket that I think we can reus

Re: Review Request 37114: MESOS-3187, support docker host command line option

> On Aug. 7, 2015, 1:31 a.m., Timothy Chen wrote: > > We already have a flag called docker_socket that I think we can reuse > > instead of doing this. Thanks .. I will make the change ... > On Aug. 7, 2015, 1:31 a.m., Timothy Chen wrote: > > src/docker/docker.hpp, line 45 > >

Re: Review Request 37114: MESOS-3187, support docker host command line option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/ --- (Updated Aug. 7, 2015, 5:04 a.m.) Review request for mesos, Benjamin Hindman, B

Re: Review Request 37114: MESOS-3187, support docker host command line option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/#review94509 --- Patch looks great! Reviews applied: [37114] All tests passed. - M

Re: Review Request 37114: MESOS-3187, support docker host command line option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/ --- (Updated Aug. 7, 2015, 9:19 p.m.) Review request for mesos, Benjamin Hindman, B

Re: Review Request 37114: MESOS-3187, support docker host command line option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/#review95137 --- src/docker/executor.hpp (line 43)

Re: Review Request 37114: MESOS-3187, support docker host command line option

> On Aug. 12, 2015, 6:13 p.m., Timothy Chen wrote: > > src/slave/flags.cpp, line 391 > > > > > > This will cause problem in the docker containerizer since we also try > > to mount in the socket when we launch execut

Re: Review Request 37114: MESOS-3187, support docker host command line option

> On Aug. 12, 2015, 6:13 p.m., Timothy Chen wrote: > > src/slave/flags.cpp, line 391 > > > > > > This will cause problem in the docker containerizer since we also try > > to mount in the socket when we launch execut

Re: Review Request 37114: MESOS-3187, support docker host command line option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/ --- (Updated Aug. 21, 2015, 6:05 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37114: MESOS-3187, support docker host command line option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/#review96064 --- src/tests/flags.hpp (line 86)

Re: Review Request 37114: MESOS-3187, support docker host command line option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/ --- (Updated Aug. 21, 2015, 8:54 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37114: MESOS-3187, support docker host command line option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/#review96360 --- src/docker/docker.hpp (line 44)

Re: Review Request 37114: MESOS-3187, support docker host command line option

> On Aug. 25, 2015, 5:05 p.m., Timothy Chen wrote: > > src/docker/docker.cpp, line 102 > > > > > > Also does this mean if a user put in tcp:/// we're just padding > > unix:///? > > I think it's safe to assume we

Re: Review Request 37114: MESOS-3187, support docker host command line option

> On Aug. 25, 2015, 5:05 p.m., Timothy Chen wrote: > > src/docker/docker.cpp, line 102 > > > > > > Also does this mean if a user put in tcp:/// we're just padding > > unix:///? > > I think it's safe to assume we

Re: Review Request 37114: MESOS-3187, support docker host command line option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/ --- (Updated Aug. 25, 2015, 7:27 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37114: MESOS-3187, support docker host command line option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/#review96408 --- Content-wise, LGTM. Style-wise, there's a bit of jaggedness in your

Re: Review Request 37114: MESOS-3187, support docker host command line option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/ --- (Updated Aug. 25, 2015, 9:29 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37114: MESOS-3187, support docker host command line option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/#review96414 --- src/docker/docker.cpp (line 104)

Re: Review Request 37114: MESOS-3187, support docker host command line option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/#review96424 --- src/docker/docker.cpp (line 104)

Re: Review Request 37114: MESOS-3187, support docker host command line option

> On Aug. 25, 2015, 9:30 p.m., Timothy Chen wrote: > > src/docker/docker.cpp, line 104 > > > > > > prefixit sounds wierd, how about prefixSocket? Will change > On Aug. 25, 2015, 9:30 p.m., Timothy Chen wrote: > >

Re: Review Request 37114: MESOS-3187, support docker host command line option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/ --- (Updated Aug. 25, 2015, 10:53 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37114: MESOS-3187, support docker host command line option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/#review96449 --- src/docker/docker.cpp (line 111)

Re: Review Request 37114: MESOS-3187, support docker host command line option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/ --- (Updated Aug. 26, 2015, 2:15 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37114: MESOS-3187, support docker host command line option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/#review96945 --- src/docker/docker.hpp (line 45)

Re: Review Request 37114: MESOS-3187, support docker host command line option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/ --- (Updated Aug. 29, 2015, 1:11 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37114: MESOS-3187, support docker host command line option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/#review96981 --- Ship it! Ship It! src/docker/docker.hpp (line 45)

Re: Review Request 37114: MESOS-3187, support docker host command line option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/#review97005 --- Can you rebase on latest master? I can't apply this patch. - Timoth

Re: Review Request 37114: MESOS-3187, support docker host command line option

> On Aug. 30, 2015, 2:15 a.m., Timothy Chen wrote: > > Can you rebase on latest master? I can't apply this patch. Kindly check now ... - Vaibhav --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/

Re: Review Request 37114: MESOS-3187, support docker host command line option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/#review97236 --- Have you ran the Docker unit tests with your change? I'm currently g

Re: Review Request 37114: MESOS-3187, support docker host command line option

> On Sept. 1, 2015, 3:59 a.m., Timothy Chen wrote: > > Have you ran the Docker unit tests with your change? I'm currently getting > > tests failed. Actually all the docker tests fail now, because of the MockDocker not being created with Docker::create and therefore isn't being injected with a

Re: Review Request 37114: MESOS-3187, support docker host command line option

> On Sept. 1, 2015, 3:59 a.m., Timothy Chen wrote: > > Have you ran the Docker unit tests with your change? I'm currently getting > > tests failed. > > Timothy Chen wrote: > Actually all the docker tests fail now, because of the MockDocker not > being created with Docker::create and theref

Re: Review Request 37114: MESOS-3187, support docker host command line option

> On Sept. 1, 2015, 3:59 a.m., Timothy Chen wrote: > > Have you ran the Docker unit tests with your change? I'm currently getting > > tests failed. > > Timothy Chen wrote: > Actually all the docker tests fail now, because of the MockDocker not > being created with Docker::create and theref

Re: Review Request 37114: MESOS-3187, support docker host command line option

> On Sept. 1, 2015, 3:59 a.m., Timothy Chen wrote: > > Have you ran the Docker unit tests with your change? I'm currently getting > > tests failed. > > Timothy Chen wrote: > Actually all the docker tests fail now, because of the MockDocker not > being created with Docker::create and theref