Re: Review Request 37442: Factor out the token extraction rules in prepartion for extending them to cope with multiple versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37442/#review97320 --- Some notes before you rebase. src/linux/perf.cpp (line 490)

Re: Review Request 37442: Factor out the token extraction rules in prepartion for extending them to cope with multiple versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37442/ --- (Updated Sept. 1, 2015, 7:49 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37442: Factor out the token extraction rules in prepartion for extending them to cope with multiple versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37442/ --- (Updated Sept. 1, 2015, 8:42 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37442: Factor out the token extraction rules in prepartion for extending them to cope with multiple versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37442/#review97359 --- Ship it! Will get this committed shortly. src/linux/perf.cpp

Re: Review Request 37442: Factor out the token extraction rules in prepartion for extending them to cope with multiple versions.

> On Sept. 1, 2015, 7:09 p.m., Ben Mahler wrote: > > src/linux/perf.cpp, line 490 > > > > > > Why not make this an Option and when it's this > > the value is None? Possible values are uint64_t, double, "" and "".

Re: Review Request 37442: Factor out the token extraction rules in prepartion for extending them to cope with multiple versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37442/ --- (Updated Aug. 31, 2015, 10:33 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37442: Factor out the token extraction rules in prepartion for extending them to cope with multiple versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37442/ --- (Updated Aug. 20, 2015, 5:31 p.m.) Review request for mesos and Ben Mahler.

Review Request 37442: Factor out the token extraction rules in prepartion for extending them to cope with multiple versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37442/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 37442: Factor out the token extraction rules in prepartion for extending them to cope with multiple versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37442/#review95371 --- Patch looks great! Reviews applied: [37423, 37424, 37417, 37416,