Re: Review Request 37462: Add support for version detection and parsing.

2015-09-02 Thread Paul Brett
> On Sept. 1, 2015, 11:43 p.m., Ben Mahler wrote: > > src/linux/perf.hpp, line 56 > > > > > > Whoops, doesn't this comment belong on the parse function? Actually, it applies to both of them. I'll make that clear.

Re: Review Request 37462: Add support for version detection and parsing.

2015-09-02 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37462/ --- (Updated Sept. 2, 2015, 6:52 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37462: Add support for version detection and parsing.

2015-09-01 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37462/ --- (Updated Sept. 1, 2015, 7:47 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37462: Add support for version detection and parsing.

2015-09-01 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37462/#review97360 --- Looks good! Should be shippable after another round.

Re: Review Request 37462: Add support for version detection and parsing.

2015-09-01 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37462/ --- (Updated Sept. 1, 2015, 8:45 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37462: Add support for version detection and parsing.

2015-08-20 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37462/ --- (Updated Aug. 21, 2015, 12:48 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37462: Add support for version detection and parsing.

2015-08-20 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37462/ --- (Updated Aug. 20, 2015, 11:49 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37462: Add support for version detection and parsing.

2015-08-20 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37462/ --- (Updated Aug. 21, 2015, midnight) Review request for mesos and Ben Mahler.

Re: Review Request 37462: Add support for version detection and parsing.

2015-08-20 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37462/ --- (Updated Aug. 20, 2015, 7:17 p.m.) Review request for mesos and Ben Mahler.

Review Request 37462: Add support for version detection and parsing.

2015-08-13 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37462/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-2834