Re: Review Request 37622: Maintenance Primitives: Shutdown & remove slave when maintenance is started.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37622/ --- (Updated Aug. 25, 2015, 2:14 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37622: Maintenance Primitives: Shutdown & remove slave when maintenance is started.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37622/ --- (Updated Aug. 26, 2015, 2:13 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37622: Maintenance Primitives: Shutdown & remove slave when maintenance is started.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37622/#review97413 --- Ship it! Ship It! - Guangya Liu On 八月 26, 2015, 2:13 a.m., Joris

Re: Review Request 37622: Maintenance Primitives: Shutdown & remove slave when maintenance is started.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37622/ --- (Updated Sept. 2, 2015, 7:33 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37622: Maintenance Primitives: Shutdown & remove slave when maintenance is started.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37622/#review97555 --- Ship it! src/master/http.cpp (line 1567)

Re: Review Request 37622: Maintenance Primitives: Shutdown & remove slave when maintenance is started.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37622/#review97884 --- src/master/http.cpp (line 1570)

Re: Review Request 37622: Maintenance Primitives: Shutdown & remove slave when maintenance is started.

> On Sept. 6, 2015, 8:14 a.m., Klaus Ma wrote: > > src/master/http.cpp, line 1570 > > > > > > Should be LostSlaveMessage? We end up sending both. I've modified the comment to make this more clear. Thanks! - Jori

Re: Review Request 37622: Maintenance Primitives: Shutdown & remove slave when maintenance is started.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37622/ --- (Updated Sept. 13, 2015, 8:34 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37622: Maintenance Primitives: Shutdown & remove slave when maintenance is started.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37622/#review98792 --- src/master/http.cpp (line 1606)

Re: Review Request 37622: Maintenance Primitives: Shutdown & remove slave when maintenance is started.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37622/#review98806 --- src/master/http.cpp (lines 1622 - 1624)

Re: Review Request 37622: Maintenance Primitives: Shutdown & remove slave when maintenance is started.

> On Sept. 14, 2015, 3:36 a.m., Benjamin Hindman wrote: > > src/master/http.cpp, lines 1622-1624 > > > > > > Why don't we want to send lost slave messages? Sorry, I meant: why don't we want to let lost slave messag

Re: Review Request 37622: Maintenance Primitives: Shutdown & remove slave when maintenance is started.

> On Sept. 14, 2015, 1:53 a.m., Qian Zhang wrote: > > src/master/http.cpp, line 1606 > > > > > > s/machineInfos/machines Nice catch! Will be fixed in updated review. - Joris

Re: Review Request 37622: Maintenance Primitives: Shutdown & remove slave when maintenance is started.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37622/ --- (Updated Sept. 14, 2015, 1:08 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37622: Maintenance Primitives: Shutdown & remove slave when maintenance is started.

> On Sept. 14, 2015, 3:36 a.m., Benjamin Hindman wrote: > > src/master/http.cpp, lines 1622-1624 > > > > > > Why don't we want to send lost slave messages? > > Benjamin Hindman wrote: > Sorry, I meant: why don'