On Aug. 27, 2015, 5:34 a.m., Neil Conway wrote:
include/mesos/mesos.proto, line 102
https://reviews.apache.org/r/37655/diff/2/?file=1049806#file1049806line102
BTW, have you considered using a simpler representation, such as just a
single int64 holding # of nanoseconds (or
On Aug. 26, 2015, 10:34 p.m., Neil Conway wrote:
Thanks for your comments!
On Aug. 26, 2015, 10:34 p.m., Neil Conway wrote:
include/mesos/mesos.proto, line 101
https://reviews.apache.org/r/37655/diff/2/?file=1049806#file1049806line101
It might be useful to specify what the
On Aug. 26, 2015, 11 p.m., Alexander Rukletsov wrote:
Do you plan to migrate existing protobufs to `TimeSpec` or use it for new
protobufs only?
For now, the plan is to have new protobufs use it. And we can change existing
protobufs to use it, if they benefit from having integer time.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37655/
---
(Updated Aug. 27, 2015, 1:14 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37655/
---
(Updated Aug. 27, 2015, 3:24 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37655/#review96778
---
include/mesos/mesos.proto (line 97)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37655/#review96648
---
include/mesos/mesos.proto (line 101)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37655/#review96244
---
Ship it!
Ship It!
include/mesos/mesos.proto (line 98)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37655/
---
(Updated Aug. 24, 2015, 5:14 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37655/#review96269
---
Ship it!
Ship It!
- Guangya Liu
On Aug. 25, 2015, 12:14 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37655/#review96285
---
Patch looks great!
Reviews applied: [37655]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37655/
---
(Updated Aug. 20, 2015, 10:03 a.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37655/#review95981
---
Patch looks great!
Reviews applied: [37655]
All tests passed.
-
13 matches
Mail list logo
