Re: Review Request 38535: Fix ExamplesTest errors when user is root.

> On Sept. 22, 2015, 6:21 a.m., Cong Wang wrote: > > src/slave/containerizer/linux_launcher.cpp, line 182 > > > > > > You forgot to remove this line? > > haosdent huang wrote: > sorry, my fault. Let me create

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

> On Sept. 22, 2015, 6:21 a.m., Cong Wang wrote: > > src/slave/containerizer/linux_launcher.cpp, line 182 > > > > > > You forgot to remove this line? sorry, my fault. - haosdent

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38535/#review99932 --- src/slave/containerizer/linux_launcher.cpp (line 182)

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

On Sept. 22, 2015, 6:21 a.m., haosdent huang wrote: > > There are two more places calling clone() in a similar way: > > src/tests/containerizer/launch_tests.cpp, > > src/tests/containerizer/ns_tests.cpp. Not sure if you need to fix them too. Hi, @wangcong Thank you very much. I submit the

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

> On Sept. 21, 2015, 10:04 p.m., Jie Yu wrote: > > OK, I'll address the comments for you since this is a blocker for the > > release. Thank you very much. - haosdent --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38535/#review99839 --- OK, I'll address the comments for you since this is a blocker for

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38535/#review99840 --- commit 57361f10ccf1e026dbb691e67277cb0cb71c8ea6 Author: haosdent

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38535/#review99764 --- src/slave/containerizer/linux_launcher.cpp (lines 184 - 186)

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

> On Sept. 21, 2015, 5:16 p.m., Jie Yu wrote: > > src/slave/containerizer/linux_launcher.cpp, lines 184-186 > > > > > > Could you please explain where the bug is in the description. I don't > > understand why this

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

> On Sept. 21, 2015, 5:16 p.m., Jie Yu wrote: > > src/slave/containerizer/linux_launcher.cpp, lines 184-186 > > > > > > Could you please explain where the bug is in the description. I don't > > understand why this

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

> On Sept. 21, 2015, 5:16 p.m., Jie Yu wrote: > > src/slave/containerizer/linux_launcher.cpp, lines 184-186 > > > > > > Could you please explain where the bug is in the description. I don't > > understand why this

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38535/#review99829 --- src/slave/containerizer/linux_launcher.cpp (line 200)

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38535/#review99698 --- Patch looks great! Reviews applied: [38535] All tests passed. -

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38535/#review99704 --- Ship it! Thanks for the catch!! LGTM module the memory leak.

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38535/ --- (Updated Sept. 20, 2015, 4:08 p.m.) Review request for mesos, Jie Yu, Joris

Review Request 38535: Fix ExamplesTest errors when user is root.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38535/ --- Review request for mesos, Jie Yu, Joris Van Remoortere, and Michael Park.

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38535/#review99705 --- Patch looks great! Reviews applied: [38535] All tests passed. -

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38535/#review99708 --- Patch looks great! Reviews applied: [38535] All tests passed. -

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38535/ --- (Updated Sept. 20, 2015, 5:04 p.m.) Review request for mesos, Jie Yu, Joris