Re: Review Request 38580: Added docker registry RemotePuller

> On Nov. 7, 2015, 9:36 a.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp, line 246 > > > > > > Can there be layers that actually have zero content? Docker images > >

Re: Review Request 38580: Added docker registry RemotePuller

> On Nov. 7, 2015, 9:36 a.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp, line 51 > > > > > > This is no longer true since we pulled these out of RemotePuller right? >

Re: Review Request 38580: Added docker registry RemotePuller

> On Nov. 4, 2015, 9:50 p.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp, line 51 > > > > > > Didn''t you pull these out? > > Jojy Varghese wrote: > Not sure what

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/ --- (Updated Nov. 8, 2015, 4:58 p.m.) Review request for mesos, Jie Yu, Timothy Che

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/#review105579 --- src/slave/containerizer/mesos/provisioner/docker/remote_puller.hpp

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/ --- (Updated Nov. 7, 2015, 12:11 a.m.) Review request for mesos, Jie Yu, Timothy Ch

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/#review105512 --- src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/ --- (Updated Nov. 6, 2015, 5:36 p.m.) Review request for mesos, Jie Yu, Timothy Che

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/ --- (Updated Nov. 5, 2015, 11:57 p.m.) Review request for mesos, Jie Yu, Timothy Ch

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/#review105325 --- src/tests/containerizer/provisioner_docker_tests.cpp (line 1191) <

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/#review105306 --- src/tests/containerizer/provisioner_docker_tests.cpp (line 1001) <

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/ --- (Updated Nov. 5, 2015, 4:03 p.m.) Review request for mesos, Jie Yu, Timothy Che

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/ --- (Updated Nov. 4, 2015, 11:27 p.m.) Review request for mesos, Jie Yu, Timothy Ch

Re: Review Request 38580: Added docker registry RemotePuller

> On Nov. 4, 2015, 10:54 p.m., Jojy Varghese wrote: > > src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp, line 373 > > > > > > Are you suggesting moving lines 373 and 374 into > > getRemoteNameFro

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/#review105167 --- src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/#review105166 --- src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp

Re: Review Request 38580: Added docker registry RemotePuller

> On Nov. 4, 2015, 9:50 p.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp, line 129 > > > > > > Move the timeout after into the RemotePullerProcess. > > Jojy Varghese

Re: Review Request 38580: Added docker registry RemotePuller

> On Nov. 4, 2015, 9:50 p.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp, line 236 > > > > > > Let's use consistent failure messaging here. > > If you like to incl

Re: Review Request 38580: Added docker registry RemotePuller

> On Nov. 4, 2015, 9:50 p.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp, line 295 > > > > > > Are you trying to check for custom registry? > > > > The Name s

Re: Review Request 38580: Added docker registry RemotePuller

> On Nov. 4, 2015, 10:05 p.m., Jojy Varghese wrote: > > src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp, line 43 > > > > > > This was done in another patch by Ben M (currently in > > registry_clie

Re: Review Request 38580: Added docker registry RemotePuller

> On Nov. 4, 2015, 9:50 p.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp, line 373 > > > > > > Instead of doing this, how about just create a new Image::Name? > > Joj

Re: Review Request 38580: Added docker registry RemotePuller

> On Nov. 4, 2015, 9:50 p.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp, line 51 > > > > > > Didn''t you pull these out? Not sure what you mean. > On Nov. 4, 2015,

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/#review105151 --- src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/#review105134 --- src/Makefile.am (line 564)

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/ --- (Updated Nov. 4, 2015, 6:09 p.m.) Review request for mesos, Jie Yu, Timothy Che

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/ --- (Updated Nov. 1, 2015, 3:38 p.m.) Review request for mesos, Jie Yu, Timothy Che

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/ --- (Updated Oct. 27, 2015, 2:27 p.m.) Review request for mesos, Jie Yu, Timothy Ch

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/ --- (Updated Oct. 27, 2015, 3:42 a.m.) Review request for mesos, Jie Yu, Timothy Ch

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/#review103930 --- Please link this RR to ticket. - Klaus Ma On Oct. 24, 2015, 12:5

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/ --- (Updated Oct. 23, 2015, 4:57 p.m.) Review request for mesos, Jie Yu, Timothy Ch

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/ --- (Updated Oct. 13, 2015, 7:19 p.m.) Review request for mesos, Jie Yu, Timothy Ch

Re: Review Request 38580: Added docker registry RemotePuller

> On Oct. 1, 2015, 6:53 p.m., Timothy Chen wrote: > > src/slave/containerizer/provisioner/docker/remote_puller.cpp, line 227 > > > > > > I thought you wanted to move this to somewhere shared? We can create a > > bas

Re: Review Request 38580: Added docker registry RemotePuller

> On Oct. 1, 2015, 6:53 p.m., Timothy Chen wrote: > > src/slave/containerizer/provisioner/docker/remote_puller.cpp, line 227 > > > > > > I thought you wanted to move this to somewhere shared? We can create a > > bas

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/ --- (Updated Oct. 12, 2015, 9:35 p.m.) Review request for mesos, Jie Yu, Timothy Ch

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/#review102161 --- src/Makefile.am (line 546)

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/ --- (Updated Oct. 8, 2015, 2:37 a.m.) Review request for mesos, Jie Yu, Timothy Che

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/ --- (Updated Oct. 6, 2015, 4:44 p.m.) Review request for mesos, Jie Yu, Timothy Che

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/ --- (Updated Oct. 5, 2015, 9:03 p.m.) Review request for mesos, Jie Yu, Timothy Che

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/ --- (Updated Oct. 2, 2015, 6:41 p.m.) Review request for mesos, Jie Yu, Timothy Che

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/#review101339 --- src/slave/containerizer/provisioner/docker/remote_puller.cpp (line

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/#review101338 --- src/slave/containerizer/provisioner/docker/registry_client.cpp (li

Re: Review Request 38580: Added docker registry RemotePuller

> On Oct. 1, 2015, 6:53 p.m., Timothy Chen wrote: > > src/slave/containerizer/provisioner/docker/remote_puller.cpp, line 227 > > > > > > I thought you wanted to move this to somewhere shared? We can create a > > bas

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/ --- (Updated Oct. 2, 2015, 5:18 p.m.) Review request for mesos, Jie Yu, Timothy Che

Re: Review Request 38580: Added docker registry RemotePuller

> On Oct. 1, 2015, 6:53 p.m., Timothy Chen wrote: > > src/slave/containerizer/provisioner/docker/remote_puller.cpp, line 227 > > > > > > I thought you wanted to move this to somewhere shared? We can create a > > bas

Re: Review Request 38580: Added docker registry RemotePuller

> On Oct. 1, 2015, 6:40 p.m., Timothy Chen wrote: > > src/slave/flags.cpp, line 118 > > > > > > s/docker/Docker/g other flags use docker currently. Do you want only this one changed to Docker or all of them? - Jo

Re: Review Request 38580: Added docker registry RemotePuller

> On Oct. 1, 2015, 6:40 p.m., Timothy Chen wrote: > > src/slave/containerizer/provisioner/docker/local_puller.hpp, line 54 > > > > > > Do we use this or set this anywhere? > > Can we remove this until we know what

Re: Review Request 38580: Added docker registry RemotePuller

> On Oct. 1, 2015, 6:53 p.m., Timothy Chen wrote: > > src/slave/containerizer/provisioner/docker/remote_puller.cpp, line 317 > > > > > > Why break down layer timeout? Why not just one timeout? > > > > And ho

Re: Review Request 38580: Added docker registry RemotePuller

> On Oct. 1, 2015, 6:53 p.m., Timothy Chen wrote: > > src/slave/containerizer/provisioner/docker/remote_puller.cpp, line 317 > > > > > > Why break down layer timeout? Why not just one timeout? > > > > And ho

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/#review101261 --- src/slave/containerizer/provisioner/docker/remote_puller.cpp (line

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/#review101260 --- src/slave/containerizer/provisioner/docker/local_puller.hpp (line

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/ --- (Updated Oct. 1, 2015, 6:40 p.m.) Review request for mesos, Jie Yu, Timothy Che

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/ --- (Updated Oct. 1, 2015, 3:32 a.m.) Review request for mesos, Jie Yu, Timothy Che

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/#review100869 --- src/slave/containerizer/provisioner/docker/remote_puller.cpp (line

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/#review100867 --- src/slave/containerizer/provisioner/docker/remote_puller.cpp (line

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/ --- (Updated Sept. 25, 2015, 11:14 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/ --- (Updated Sept. 25, 2015, 8:32 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/ --- (Updated Sept. 25, 2015, 6:34 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/#review100594 --- Please rebase on latest master - Timothy Chen On Sept. 22, 2015,

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/ --- (Updated Sept. 22, 2015, 11:38 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/#review99905 --- Patch looks great! Reviews applied: [38443, 38579, 38580] All test

Review Request 38580: Added docker registry RemotePuller

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38580/ --- Review request for mesos and Timothy Chen. Repository: mesos Description