Re: Review Request 38625: Replace clone system call with os::clone

2015-09-22 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38625/ --- (Updated Sept. 22, 2015, 6:52 p.m.) Review request for mesos, Jie Yu, Joris

Re: Review Request 38625: Replace clone system call with os::clone

2015-09-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38625/#review100050 --- Ship it! src/tests/containerizer/ns_tests.cpp (lines 169 - 171)

Re: Review Request 38625: Replace clone system call with os::clone

2015-09-22 Thread haosdent huang
> On Sept. 22, 2015, 4:51 p.m., Cong Wang wrote: > > Why not introduce a wrapper for clone() to hide the 'stack'? > > haosdent huang wrote: > Sure, let me update again. @wangcong I finish update the patch. Could you help review this again? Thank you very much. - haosdent

Re: Review Request 38625: Replace clone system call with os::clone

2015-09-22 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38625/ --- (Updated Sept. 23, 2015, 1:25 a.m.) Review request for mesos, Jie Yu, Joris

Re: Review Request 38625: Replace clone system call with os::clone

2015-09-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38625/#review100068 --- Patch looks great! Reviews applied: [38639, 38625] All tests

Re: Review Request 38625: Replace clone system call with os::clone

2015-09-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38625/#review100128 --- Patch looks great! Reviews applied: [38639, 38625] All tests