Re: Review Request 38639: Add os::clone function in stout.

> On Sept. 22, 2015, 6:55 p.m., Cong Wang wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp, line 52 > > > > > > s/namespaces/flags/, because SIG* can be or'ed with namespaces. Or even > >

Re: Review Request 38639: Add os::clone function in stout.

> On Sept. 22, 2015, 6:55 p.m., Cong Wang wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp, line 52 > > > > > > s/namespaces/flags/, because SIG* can be or'ed with namespaces. Or even > >

Re: Review Request 38639: Add os::clone function in stout.

> On Sept. 22, 2015, 6:55 p.m., Cong Wang wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp, line 52 > > > > > > s/namespaces/flags/, because SIG* can be or'ed with namespaces. Or even > >

Re: Review Request 38639: Add os::clone function in stout.

> On Sept. 23, 2015, 5:43 a.m., Cong Wang wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp, line 138 > > > > > > This whitespace change is not supposed in this patch. I'll commit this one

Re: Review Request 38639: Add os::clone function in stout.

> On Sept. 22, 2015, 6:55 p.m., Cong Wang wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp, line 52 > > > > > > s/namespaces/flags/, because SIG* can be or'ed with namespaces. Or even > >

Re: Review Request 38639: Add os::clone function in stout.

> On Sept. 22, 2015, 2:58 p.m., Kapil Arya wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp, line 73 > > > > > > We should delete the stack only if CLONE_VM was not specified in the > > flags

Re: Review Request 38639: Add os::clone function in stout.

> On Sept. 22, 2015, 6:58 p.m., Kapil Arya wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp, line 73 > > > > > > We should delete the stack only if CLONE_VM was not specified in the > > flags

Re: Review Request 38639: Add os::clone function in stout.

> On Sept. 22, 2015, 6:58 p.m., Kapil Arya wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp, line 73 > > > > > > We should delete the stack only if CLONE_VM was not specified in the > > flags

Re: Review Request 38639: Add os::clone function in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38639/#review100042 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp

Re: Review Request 38639: Add os::clone function in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38639/#review100046 --- Ship it!

Re: Review Request 38639: Add os::clone function in stout.

> On Sept. 22, 2015, 6:55 p.m., Cong Wang wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp, line 52 > > > > > > s/namespaces/flags/, because SIG* can be or'ed with namespaces. Or even > >

Re: Review Request 38639: Add os::clone function in stout.

> On Sept. 22, 2015, 6:58 p.m., Kapil Arya wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp, line 73 > > > > > > We should delete the stack only if CLONE_VM was not specified in the > > flags

Re: Review Request 38639: Add os::clone function in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38639/ --- (Updated Sept. 23, 2015, 1:26 a.m.) Review request for mesos, Jie Yu and Cong

Re: Review Request 38639: Add os::clone function in stout.

> On Sept. 22, 2015, 6:55 p.m., Cong Wang wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp, line 52 > > > > > > s/namespaces/flags/, because SIG* can be or'ed with namespaces. Or even > >

Re: Review Request 38639: Add os::clone function in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38639/#review100139 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp