Re: Review Request 38645: Fixed Flaky Executor HTTP tests

2015-09-24 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38645/ --- (Updated Sept. 24, 2015, 11:24 p.m.) Review request for mesos, Isabel Jimenez

Re: Review Request 38645: Fixed Flaky Executor HTTP tests

2015-09-24 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38645/#review100499 --- Ship it! Ship It! - Vinod Kone On Sept. 24, 2015, 11:24 p.m.,

Re: Review Request 38645: Fixed Flaky Executor HTTP tests

2015-09-24 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38645/ --- (Updated Sept. 24, 2015, 11:09 p.m.) Review request for mesos, Isabel Jimenez

Re: Review Request 38645: Fixed Flaky Executor HTTP tests

2015-09-24 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38645/ --- (Updated Sept. 24, 2015, 11:48 p.m.) Review request for mesos, Isabel Jimenez

Re: Review Request 38645: Fixed Flaky Executor HTTP tests

2015-09-24 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38645/#review100477 --- src/tests/executor_http_api_tests.cpp (line 95)

Re: Review Request 38645: Fixed Flaky Executor HTTP tests

2015-09-22 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38645/#review100066 --- For the sake of repro'ing, maybe you could add a sleep before

Re: Review Request 38645: Fixed Flaky Executor HTTP tests

2015-09-22 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38645/ --- (Updated Sept. 22, 2015, 8:46 p.m.) Review request for mesos, Isabel Jimenez

Re: Review Request 38645: Fixed Flaky Executor HTTP tests

2015-09-22 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38645/ --- (Updated Sept. 22, 2015, 9:37 p.m.) Review request for mesos, Isabel Jimenez

Re: Review Request 38645: Fixed Flaky Executor HTTP tests

2015-09-22 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38645/#review100072 --- Ship it! Ship It! - Neil Conway On Sept. 22, 2015, 9:37 p.m.,

Re: Review Request 38645: Fixed Flaky Executor HTTP tests

2015-09-22 Thread Anand Mazumdar
> On Sept. 22, 2015, 9:09 p.m., Neil Conway wrote: > > For the sake of repro'ing, maybe you could add a sleep before waiting on > > the future? Obviously not something we want in the actual patch though. Thanks Neil, that worked. Updated the `Testing Done` section with the details now. Should

Review Request 38645: Fixed Flaky Executor HTTP tests

2015-09-22 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38645/ --- Review request for mesos, Isabel Jimenez and Vinod Kone. Repository: mesos

Re: Review Request 38645: Fixed Flaky Executor HTTP tests

2015-09-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38645/#review100103 --- Patch looks great! Reviews applied: [38645] All tests passed. -