Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Jan. 7, 2016, 4:01 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review113242 --- Great stuff, happy to see it landing! Some general suggestions,

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

> On Jan. 7, 2016, 3:28 p.m., Alexander Rukletsov wrote: > > src/master/master.hpp, lines 1187-1190 > > > > > > Let's remove this in a patch chained to this review (and fix MESOS-4149 > > as a consequence) in

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review113377 --- This looks ready Alexander. Let me fix most issues marked here

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Jan. 7, 2016, 5:41 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

> On Jan. 7, 2016, 4:28 p.m., Alexander Rukletsov wrote: > > src/tests/mesos.cpp, lines 435-438 > > > > > > Since `setAuthenticator` is called in `Master::initialize()` won't it > > be a problem if we have

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Jan. 7, 2016, 5:03 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

> On Jan. 7, 2016, 3:28 p.m., Alexander Rukletsov wrote: > > src/tests/mesos.cpp, lines 435-438 > > > > > > Since `setAuthenticator` is called in `Master::initialize()` won't it > > be a problem if we have

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review113276 --- Ship it! Ship It! - Greg Mann On Jan. 7, 2016, 4:41 p.m.,

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Jan. 6, 2016, 2:47 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Jan. 6, 2016, 4:27 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

> On Jan. 6, 2016, 3:45 p.m., Jan Schlicht wrote: > > src/master/constants.hpp, line 137 > > > > > > s/mesos/Mesos The string there is the actual value of the string, which is "mesos". That is the pattern in this

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

> On Jan. 6, 2016, 3:45 p.m., Jan Schlicht wrote: > > src/master/http.cpp, line 606 > > > > > > You're changing this to `Forbidden()` here and in > > `Master::Http::destroyVolumes`, which has to do with RFC-2616.

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Jan. 6, 2016, 3:44 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review113065 --- include/mesos/authentication/http/basic_authenticator_factory.hpp

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

> On Jan. 6, 2016, 6:45 a.m., Jan Schlicht wrote: > > src/master/constants.hpp, line 137 > > > > > > s/mesos/Mesos > > Alexander Rojas wrote: > The string there is the actual value of the string, which is

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review113108 --- Bad patch! Reviews applied: [40539, 37999, 38000, 38094, 38950,

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Jan. 6, 2016, 9:03 a.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Jan. 5, 2016, 5:20 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

> On Jan. 5, 2016, 1:57 p.m., Bernd Mathiske wrote: > > src/master/master.cpp, line 528 > > > > > > Isn't there a version of BasicAuthenticatorFactory::create() that takes > > credentials instead of parameters?

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review112860 --- Patch looks great! Reviews applied: [40539, 37999, 38000, 38094,

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review112877 --- src/master/master.cpp (line 505)

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review112944 --- Patch looks great! Reviews applied: [40539, 37999, 38000, 38094,

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Jan. 5, 2016, 12:18 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review112830 --- src/master/http.cpp (line 1661)

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Dec. 14, 2015, 4:02 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

> On Dec. 11, 2015, 2:41 p.m., Bernd Mathiske wrote: > > src/master/master.cpp, line 509 > > > > > > Why do we have a vector then? > > Why do we have plural variable names then? > > I suspect this is an MVP

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Dec. 11, 2015, 3:06 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review109955 --- src/master/flags.cpp (line 438)

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review109799 --- Patch looks great! Reviews applied: [40539, 37999, 38000, 38094,

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Dec. 10, 2015, 3:34 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Dec. 8, 2015, 11:24 a.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review109318 --- src/master/constants.cpp (line 49)

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

> On Dec. 8, 2015, 3:07 p.m., Alexander Rukletsov wrote: > > src/master/master.cpp, lines 475-478 > > > > > > I'm slightly confused. Now we have two different authenticators: one > > for frameworks and one for

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Dec. 8, 2015, 4:53 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

> On Dec. 8, 2015, 2:07 p.m., Alexander Rukletsov wrote: > > src/master/http.cpp, lines 2276-2282 > > > > > > Looks like the scope of the `Credential` protobuf is reduced. It looks > > like now it's only used to

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review109358 --- Patch looks great! Reviews applied: [40539, 37999, 38000, 38094,

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Dec. 7, 2015, 3:22 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Dec. 7, 2015, 2:33 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review109249 --- Bad patch! Reviews applied: [40539, 37999, 38000, 38094, 38950]

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Nov. 17, 2015, 2:37 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review106860 --- Bad patch! Reviews applied: [40226, 40227, 39276, 37998, 37999,

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Nov. 16, 2015, 5:28 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review106683 --- Bad patch! Reviews applied: [40226, 40227, 39276, 37998, 37999,

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review106643 --- Bad patch! Reviews applied: [38627, 40226, 40227, 39276, 37998,

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Nov. 16, 2015, 11:06 a.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review105788 --- Patch looks great! Reviews applied: [39276, 37998, 37999, 38000,

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Nov. 10, 2015, 5:03 a.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review105787 --- Bad patch! Reviews applied: [39276] Failed command:

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Nov. 9, 2015, 11:38 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review105768 --- Bad patch! Reviews applied: [39276] Failed command:

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Nov. 5, 2015, 6:26 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review105286 --- Patch looks great! Reviews applied: [39276, 37998, 37999, 38000,

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Nov. 4, 2015, 12:33 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review105060 --- Patch looks great! Reviews applied: [39276, 37998, 39472, 37999,

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Nov. 4, 2015, 1:21 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review105056 --- Bad patch! Reviews applied: [39276, 37998, 39472, 37999, 38000,

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review103583 --- Patch looks great! Reviews applied: [39276, 37998, 39472, 37999,

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Oct. 22, 2015, 3:01 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review103402 --- src/master/master.cpp (line 510)

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review103407 --- Patch looks great! Reviews applied: [39276, 37998, 39472, 37999,

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Oct. 21, 2015, 2:55 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review103399 --- Bad patch! Reviews applied: [39276, 37998, 39472, 37999, 38000,

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Oct. 21, 2015, 3:20 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/ --- (Updated Oct. 20, 2015, 12:30 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review103238 --- Patch looks great! Reviews applied: [39472, 39276, 37998, 37999,

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review103329 --- src/master/flags.cpp (line 442)

Re: Review Request 39043: Added support for HTTP Authentication in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39043/#review101650 --- Patch looks great! Reviews applied: [37714, 37996, 37997, 37998,