Re: Review Request 39104: Added source address to logging when we receive replicated log events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39104/#review101849 --- Patch looks great! Reviews applied: [39104] All tests passed. -

Re: Review Request 39104: Added source address to logging when we receive replicated log events.

> On Oct. 7, 2015, 10:06 p.m., Anand Mazumdar wrote: > > src/log/replica.cpp, line 378 > > > > > > Nit : This line is > 80 chars. Can we wrap this ? > > Neil Conway wrote: > That line is 74 characters long, by m

Re: Review Request 39104: Added source address to logging when we receive replicated log events.

> On Oct. 7, 2015, 10:06 p.m., Anand Mazumdar wrote: > > src/log/replica.cpp, line 378 > > > > > > Nit : This line is > 80 chars. Can we wrap this ? That line is 74 characters long, by my count :) - Neil ---

Re: Review Request 39104: Added source address to logging when we receive replicated log events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39104/#review101822 --- Ship it! LGTM src/log/replica.cpp (line 378)

Re: Review Request 39104: Added source address to logging when we receive replicated log events.

> On Oct. 7, 2015, 2:52 p.m., Adam B wrote: > > LGTM. > > Since the 'Summary' and 'Description fields are used to create the git > > commit message, I'd like to see the 'Description' be more descriptive; or > > just say "See summary", which means "do not include in commit message". > > Neil Co

Re: Review Request 39104: Added source address to logging when we receive replicated log events.

> On Oct. 7, 2015, 9:52 p.m., Adam B wrote: > > LGTM. > > Since the 'Summary' and 'Description fields are used to create the git > > commit message, I'd like to see the 'Description' be more descriptive; or > > just say "See summary", which means "do not include in commit message". Okay. Just

Re: Review Request 39104: Added source address to logging when we receive replicated log events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39104/#review101818 --- Ship it! Ship It! - Jie Yu On Oct. 7, 2015, 9:41 p.m., Neil Con

Re: Review Request 39104: Added source address to logging when we receive replicated log events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39104/#review101817 --- Ship it! LGTM. Since the 'Summary' and 'Description fields are use

Review Request 39104: Added source address to logging when we receive replicated log events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39104/ --- Review request for mesos, Adam B and Joris Van Remoortere. Bugs: MESOS-3417