Re: Review Request 39141: Store: minor style changes

2015-10-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39141/#review101971 --- Ship it! Ship It! - Timothy Chen On Oct. 8, 2015, 9:51 p.m., Jo

Re: Review Request 39141: Store: minor style changes

2015-10-08 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39141/#review101964 --- Ship it! Ship It! - Anand Mazumdar On Oct. 8, 2015, 9:51 p.m.,

Re: Review Request 39141: Store: minor style changes

2015-10-08 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39141/ --- (Updated Oct. 8, 2015, 9:51 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 39141: Store: minor style changes

2015-10-08 Thread Jojy Varghese
> On Oct. 8, 2015, 7:40 p.m., Anand Mazumdar wrote: > > src/slave/containerizer/provisioner/docker/store.cpp, line 202 > > > > > > In this particular case, `push_back` would also do a `std::move` for a > > temporary

Re: Review Request 39141: Store: minor style changes

2015-10-08 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39141/#review101951 --- src/slave/containerizer/provisioner/docker/store.cpp (line 202)

Review Request 39141: Store: minor style changes

2015-10-08 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39141/ --- Review request for mesos and Timothy Chen. Repository: mesos Description