Re: Review Request 39208: Windows: Add windows support to `stout/protobuf.hpp`.

2015-10-17 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39208/#review103037 --- Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/protobu

Re: Review Request 39208: Windows: Add windows support to `stout/protobuf.hpp`.

2015-10-13 Thread Joseph Wu
> On Oct. 12, 2015, 2:13 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp, lines 41-42 > > > > > > Do you want to `#include ` too? > > Alex Clemmer wrote: > Interesting, yo

Re: Review Request 39208: Windows: Add windows support to `stout/protobuf.hpp`.

2015-10-13 Thread Alex Clemmer
> On Oct. 12, 2015, 9:13 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp, lines 41-42 > > > > > > Do you want to `#include ` too? Interesting, you must be seeing good reasons

Re: Review Request 39208: Windows: Add windows support to `stout/protobuf.hpp`.

2015-10-13 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39208/ --- (Updated Oct. 13, 2015, 6:31 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 39208: Windows: Add windows support to `stout/protobuf.hpp`.

2015-10-12 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39208/#review102325 --- Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/protobu

Review Request 39208: Windows: Add windows support to `stout/protobuf.hpp`.

2015-10-10 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39208/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu