Re: Review Request 39213: Windows: Moved `bootId` to is own file, `stout/os/windows/bootid.hpp`.

2015-10-19 Thread Ben Mahler
> On Oct. 18, 2015, 4:18 p.m., Joris Van Remoortere wrote: > > We can use snake case in stout. What made you think that? We certainly haven't been doing that intentionally, and this is still called bootId(), not boot_id().. although I see some snake case slipped in :( - Ben

Re: Review Request 39213: Windows: Moved `bootId` to is own file, `stout/os/windows/bootid.hpp`.

2015-10-18 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39213/#review103058 --- Ship it! We can use snake case in stout.

Re: Review Request 39213: Windows: Moved `bootId` to is own file, `stout/os/windows/bootid.hpp`.

2015-10-13 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39213/ --- (Updated Oct. 13, 2015, 6:34 p.m.) Review request for mesos, Artem

Re: Review Request 39213: Windows: Moved `bootId` to is own file, `stout/os/windows/bootid.hpp`.

2015-10-12 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39213/ --- (Updated Oct. 12, 2015, 6:16 a.m.) Review request for mesos, Artem

Re: Review Request 39213: Windows: Moved `bootId` to is own file, `stout/os/windows/bootid.hpp`.

2015-10-12 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39213/#review102337 --- Ship it!

Review Request 39213: Windows: Moved `bootId` to is own file, `stout/os/windows/bootid.hpp`.

2015-10-11 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39213/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph