Re: Review Request 39338: Added code that appends the fetcher log to the agent log upon fetcher failure.

2015-10-16 Thread Ben Mahler
> On Oct. 16, 2015, 7:29 a.m., Adam B wrote: > > src/slave/containerizer/fetcher.cpp, line 794 > > > > > > What's this string parameter that you're ignoring? If it's the Failure > > message, I'd think you'd want to

Re: Review Request 39338: Added code that appends the fetcher log to the agent log upon fetcher failure.

2015-10-16 Thread Adam B
> On Oct. 15, 2015, 6:24 a.m., Benjamin Bannier wrote: > > src/slave/containerizer/fetcher.cpp, line 799 > > > > > > It would probably be better to stream the full message into the `LOG` > > object to get the full

Re: Review Request 39338: Added code that appends the fetcher log to the agent log upon fetcher failure.

2015-10-16 Thread Bernd Mathiske
> On Oct. 16, 2015, 12:29 a.m., Adam B wrote: > > src/slave/containerizer/fetcher.cpp, line 794 > > > > > > What's this string parameter that you're ignoring? If it's the Failure > > message, I'd think you'd want

Re: Review Request 39338: Added code that appends the fetcher log to the agent log upon fetcher failure.

2015-10-16 Thread Bernd Mathiske
> On Oct. 16, 2015, 12:29 a.m., Adam B wrote: > > src/slave/containerizer/fetcher.cpp, line 794 > > > > > > What's this string parameter that you're ignoring? If it's the Failure > > message, I'd think you'd want

Re: Review Request 39338: Added code that appends the fetcher log to the agent log upon fetcher failure.

2015-10-16 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39338/ --- (Updated Oct. 16, 2015, 1:56 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 39338: Added code that appends the fetcher log to the agent log upon fetcher failure.

2015-10-16 Thread Adam B
> On Oct. 16, 2015, 12:29 a.m., Adam B wrote: > > src/slave/containerizer/fetcher.cpp, line 794 > > > > > > What's this string parameter that you're ignoring? If it's the Failure > > message, I'd think you'd want

Review Request 39338: Added code that appends the fetcher log to the agent log upon fetcher failure.

2015-10-15 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39338/ --- Review request for mesos, Benjamin Bannier, Ben Mahler, and Till Toenshoff.

Re: Review Request 39338: Added code that appends the fetcher log to the agent log upon fetcher failure.

2015-10-15 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39338/#review102777 --- src/slave/containerizer/fetcher.cpp (line 703)

Re: Review Request 39338: Added code that appends the fetcher log to the agent log upon fetcher failure.

2015-10-15 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39338/#review102779 --- Ship it! src/slave/containerizer/fetcher.cpp (line 703)

Re: Review Request 39338: Added code that appends the fetcher log to the agent log upon fetcher failure.

2015-10-15 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39338/#review102848 --- Ship it! Ship It! - Marco Massenzio On Oct. 15, 2015, 1:11