Re: Review Request 39345: Enable build on FreeBSD, start porting components.

2015-10-25 Thread David Forsythe
> On Oct. 21, 2015, 7:17 p.m., Ian Downes wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 257 > > > > > > What happens if/when we support IPv6? We could just check ip.family() for

Re: Review Request 39345: Enable build on FreeBSD, start porting components.

2015-10-21 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39345/#review103449 --- Looks good! I haven't tested this myself yet, so these are

Re: Review Request 39345: Enable build on FreeBSD, start porting components.

2015-10-21 Thread Ian Downes
> On Oct. 20, 2015, 1:52 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [39345] > > > > Failed command: ./support/apply-review.sh -n -r 39345 > > > > Error: > > 2015-10-20 08:52:33 URL:https://reviews.apache.org/r/39345/diff/raw/ > > [26851/26851] -> "39345.patch" [1]

Re: Review Request 39345: Enable build on FreeBSD, start porting components.

2015-10-20 Thread David Forsythe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39345/ --- (Updated Oct. 20, 2015, 7:45 a.m.) Review request for mesos and Ian Downes.

Re: Review Request 39345: Enable build on FreeBSD, start porting components.

2015-10-19 Thread David Forsythe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39345/ --- (Updated Oct. 19, 2015, 9:06 p.m.) Review request for mesos and Ian Downes.

Re: Review Request 39345: Enable build on FreeBSD, start porting components.

2015-10-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39345/#review103180 --- Bad patch! Reviews applied: [39345] Failed command:

Re: Review Request 39345: Enable build on FreeBSD, start porting components.

2015-10-19 Thread David Forsythe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39345/ --- (Updated Oct. 20, 2015, 3:14 a.m.) Review request for mesos and Ian Downes.

Re: Review Request 39345: Enable build on FreeBSD, start porting components.

2015-10-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39345/#review102795 --- Bad patch! Reviews applied: [39345] Failed command:

Review Request 39345: Enable build on FreeBSD, start porting components.

2015-10-15 Thread David Forsythe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39345/ --- Review request for mesos and Ian Downes. Bugs:

Re: Review Request 39345: Enable build on FreeBSD, start porting components.

2015-10-15 Thread David Forsythe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39345/ --- (Updated Oct. 15, 2015, 5:16 p.m.) Review request for mesos and Ian Downes.