Re: Review Request 39382: Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.

2015-10-20 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39382/#review103283 --- Ship it! I added a patch before this similar to the other "prepare

Re: Review Request 39382: Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.

2015-10-20 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39382/ --- (Updated Oct. 20, 2015, 7:20 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 39382: Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.

2015-10-19 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39382/ --- (Updated Oct. 19, 2015, 11:27 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 39382: Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.

2015-10-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39382/#review103024 --- Bad patch! Reviews applied: [39076, 39091, 39092, 39093, 39096, 39

Re: Review Request 39382: Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.

2015-10-17 Thread Alex Clemmer
> On Oct. 16, 2015, 9:19 p.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [39076, 39091, 39092, 39093, 39096, 39097, 39180] > > > > Failed command: ./support/apply-review.sh -n -r 39180 > > > > Error: > > 2015-10-16 21:19:05 URL:https://reviews.apache.org/r/39180/diff/raw/

Re: Review Request 39382: Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.

2015-10-17 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39382/ --- (Updated Oct. 17, 2015, 6:54 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 39382: Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.

2015-10-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39382/#review102993 --- Bad patch! Reviews applied: [39076, 39091, 39092, 39093, 39096, 39

Re: Review Request 39382: Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.

2015-10-16 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39382/#review102980 --- Ship it! Ship It! - Joseph Wu On Oct. 16, 2015, 12:50 p.m., Ale

Re: Review Request 39382: Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.

2015-10-16 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39382/ --- (Updated Oct. 16, 2015, 7:50 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 39382: Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.

2015-10-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39382/#review102881 --- Bad patch! Reviews applied: [39076, 39091, 39092, 39093, 39096, 39

Review Request 39382: Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.

2015-10-15 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39382/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu