Re: Review Request 39429: Replaced volatile, GCC intrinsics with std::atomic.

2015-10-20 Thread Neil Conway
> On Oct. 20, 2015, 7 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/include/process/owned.hpp, lines 202-203 > > > > > > In libprocess we use `snake_case`. > > You can also consider removing the tempo

Re: Review Request 39429: Replaced volatile, GCC intrinsics with std::atomic.

2015-10-20 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39429/ --- (Updated Oct. 20, 2015, 8:18 p.m.) Review request for mesos and Joris Van Remoo

Re: Review Request 39429: Replaced volatile, GCC intrinsics with std::atomic.

2015-10-20 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39429/#review103292 --- Ship it! 3rdparty/libprocess/include/process/owned.hpp (lines 202

Re: Review Request 39429: Replaced volatile, GCC intrinsics with std::atomic.

2015-10-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39429/#review103106 --- Patch looks great! Reviews applied: [39428, 39429] All tests pass

Re: Review Request 39429: Replaced volatile, GCC intrinsics with std::atomic.

2015-10-18 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39429/ --- (Updated Oct. 19, 2015, 4:48 a.m.) Review request for mesos and Joris Van Remoo

Re: Review Request 39429: Replaced volatile, GCC intrinsics with std::atomic.

2015-10-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39429/#review103095 --- Bad patch! Reviews applied: [39428, 39429] Failed command: ./supp

Review Request 39429: Replaced volatile, GCC intrinsics with std::atomic.

2015-10-18 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39429/ --- Review request for mesos and Joris Van Remoortere. Bugs: MESOS-3326 https:/