Re: Review Request 40654: Cleaned up usage of `CreateSlaveFlags()` in a test file.

2015-11-26 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40654/#review108168 --- Ship it! Ship It! - Till Toenshoff On Nov. 25, 2015, 2:32 a.m.,

Re: Review Request 40654: Cleaned up usage of `CreateSlaveFlags()` in a test file.

2015-11-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40654/#review107983 --- Ship it! There are also other files need to be updated, but I thin

Re: Review Request 40654: Cleaned up usage of `CreateSlaveFlags()` in a test file.

2015-11-24 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40654/ --- (Updated Nov. 25, 2015, 2:32 a.m.) Review request for mesos and Ben Mahler. C

Re: Review Request 40654: Cleaned up usage of `CreateSlaveFlags()` in a test file.

2015-11-24 Thread Neil Conway
> On Nov. 25, 2015, 2:25 a.m., Guangya Liu wrote: > > src/tests/authentication_tests.cpp, line 311 > > > > > > Not yours but do you mind to update s/Try >/Try> > > and the following? Sure -- although I believe that

Re: Review Request 40654: Cleaned up usage of `CreateSlaveFlags()` in a test file.

2015-11-24 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40654/#review107899 --- src/tests/authentication_tests.cpp (line 311)

Review Request 40654: Cleaned up usage of `CreateSlaveFlags()` in a test file.

2015-11-24 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40654/ --- Review request for mesos and Ben Mahler. Repository: mesos Description --