Re: Review Request 41158: Turn off rx checksum offloading for veth in container

> On Dec. 10, 2015, 12:27 a.m., Jie Yu wrote: > > This is more like a question: do we need to turn off tx side as well? This is not needed, because 1) the physical interface can finally checksum it after it moves out of the container to the gateway interface; 2) if the physcial interface is

Re: Review Request 41158: Turn off rx checksum offloading for veth in container

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41158/#review109719 --- Patch looks great! Reviews applied: [41158] Passed command:

Re: Review Request 41158: Turn off rx checksum offloading for veth in container

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41158/#review109903 --- src/slave/containerizer/mesos/isolators/network/port_mapping.cpp

Re: Review Request 41158: Turn off rx checksum offloading for veth in container

> On Dec. 11, 2015, 1:16 a.m., David Robinson wrote: > > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp, lines > > 1097-1098 > > > > > > This writes to stderr, which can end up in the logs. > >

Re: Review Request 41158: Turn off rx checksum offloading for veth in container

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41158/ --- (Updated Dec. 9, 2015, 3:15 p.m.) Review request for mesos, Ian Downes and Jie

Re: Review Request 41158: Turn off rx checksum offloading for veth in container

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41158/#review109644 --- This is more like a question: do we need to turn off tx side as

Review Request 41158: Turn off rx checksum offloading for veth in container

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41158/ --- Review request for mesos, Ian Downes and Jie Yu. Repository: mesos

Re: Review Request 41158: Turn off rx checksum offloading for veth in container

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41158/#review109641 --- Ship it! Ship It! - Jie Yu On Dec. 9, 2015, 11:15 p.m., Cong

Re: Review Request 41158: Turn off rx checksum offloading for veth in container

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41158/#review109627 --- Ship it!