Re: Review Request 41235: Cleaned up the untar method in docker puller.

> On Dec. 11, 2015, 7 p.m., Jojy Varghese wrote: > > src/slave/containerizer/mesos/provisioner/docker/puller.cpp, line 117 > > > > > > If the future is not expected to be ready when we reach here, should we > > do a

Re: Review Request 41235: Cleaned up the untar method in docker puller.

> On Dec. 11, 2015, 7 p.m., Jojy Varghese wrote: > > src/slave/containerizer/mesos/provisioner/docker/puller.cpp, line 117 > > > > > > If the future is not expected to be ready when we reach here, should we > > do a

Re: Review Request 41235: Cleaned up the untar method in docker puller.

> On Dec. 11, 2015, 7 p.m., Jojy Varghese wrote: > > src/slave/containerizer/mesos/provisioner/docker/puller.cpp, line 117 > > > > > > If the future is not expected to be ready when we reach here, should we > > do a

Re: Review Request 41235: Cleaned up the untar method in docker puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41235/ --- (Updated Dec. 11, 2015, 7:51 p.m.) Review request for mesos, Ben Mahler, Gilber

Re: Review Request 41235: Cleaned up the untar method in docker puller.

> On Dec. 11, 2015, 7 p.m., Jojy Varghese wrote: > > src/slave/containerizer/mesos/provisioner/docker/puller.cpp, line 117 > > > > > > If the future is not expected to be ready when we reach here, should we > > do a

Re: Review Request 41235: Cleaned up the untar method in docker puller.

> On Dec. 11, 2015, 7 p.m., Jojy Varghese wrote: > > src/slave/containerizer/mesos/provisioner/docker/puller.cpp, line 96 > > > > > > The pattern I have seen in the code is that we dont log failures and it > > pops u

Re: Review Request 41235: Cleaned up the untar method in docker puller.

> On Dec. 11, 2015, 7 p.m., Jojy Varghese wrote: > > src/slave/containerizer/mesos/provisioner/docker/puller.cpp, line 96 > > > > > > The pattern I have seen in the code is that we dont log failures and it > > pops u

Re: Review Request 41235: Cleaned up the untar method in docker puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41235/#review109986 --- src/slave/containerizer/mesos/provisioner/docker/puller.cpp

Re: Review Request 41235: Cleaned up the untar method in docker puller.

> On Dec. 11, 2015, 6:42 p.m., Jojy Varghese wrote: > > src/slave/containerizer/mesos/provisioner/docker/puller.cpp, line 117 > > > > > > Are we always expecting the future to be ready when we get here? Not really.

Re: Review Request 41235: Cleaned up the untar method in docker puller.

> On Dec. 11, 2015, 6:42 p.m., Jojy Varghese wrote: > > src/slave/containerizer/mesos/provisioner/docker/puller.cpp, line 96 > > > > > > Wondering why we removed error context like the name of the file. > > Wouldnt t

Re: Review Request 41235: Cleaned up the untar method in docker puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41235/#review109981 --- src/slave/containerizer/mesos/provisioner/docker/puller.cpp

Re: Review Request 41235: Cleaned up the untar method in docker puller.

> On Dec. 11, 2015, 6:33 p.m., Ben Mahler wrote: > > src/slave/containerizer/mesos/provisioner/docker/puller.cpp, line 37 > > > > > > We've been trying to eliminate these in favor of non-namespace using > > statement

Re: Review Request 41235: Cleaned up the untar method in docker puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41235/#review109978 --- Ship it! Thanks Jie!! src/slave/containerizer/mesos/provisioner/

Re: Review Request 41235: Cleaned up the untar method in docker puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41235/#review109973 --- Ship it! Ship It! - Gilbert Song On Dec. 10, 2015, 5:35 p.m., J

Re: Review Request 41235: Cleaned up the untar method in docker puller.

> On Dec. 11, 2015, 10:06 a.m., Gilbert Song wrote: > > Ship It! Tested. Checked that logic does not change, but more clearer. - Gilbert --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41235

Review Request 41235: Cleaned up the untar method in docker puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41235/ --- Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy C