Re: Review Request 42040: Added Quota Operator Documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42040/#review114892 --- Ship it! Ship It! - Joris Van Remoortere On Jan. 13, 2016, 2:43

Re: Review Request 42040: Added Quota Operator Documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42040/ --- (Updated Jan. 13, 2016, 2:43 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 42040: Added Quota Operator Documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42040/ --- (Updated Jan. 13, 2016, 1:53 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 42040: Added Quota Operator Documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42040/#review113982 --- Patch looks great! Reviews applied: [42040] Passed command: expor

Re: Review Request 42040: Added Quota Operator Documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42040/ --- (Updated Jan. 12, 2016, 8:54 a.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 42040: Added Quota Operator Documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42040/ --- (Updated Jan. 12, 2016, 8:42 a.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 42040: Added Quota Operator Documentation.

> On Jan. 12, 2016, 3 a.m., Alexander Rukletsov wrote: > > docs/quota.md, line 313 > > > > > > Is there a trailing blank line? In my patch yes. Not sure what rb does... - Joerg --

Re: Review Request 42040: Added Quota Operator Documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42040/#review113916 --- Ship it! docs/quota.md (line 61)

Re: Review Request 42040: Added Quota Operator Documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42040/#review113873 --- Patch looks great! Reviews applied: [42040] Passed command: expor

Re: Review Request 42040: Added Quota Operator Documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42040/#review113815 --- Ship it! Ship It! - Neil Conway On Jan. 11, 2016, 6:51 p.m., Jo

Re: Review Request 42040: Added Quota Operator Documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42040/ --- (Updated Jan. 11, 2016, 6:51 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 42040: Added Quota Operator Documentation.

> On Jan. 7, 2016, 11:55 p.m., Neil Conway wrote: > > docs/quota.md, line 21 > > > > > > Is the analogy between quota and dynamic reservation accurate/helpful? > > A dynamic reservation reserves _particular_ resource

Re: Review Request 42040: Added Quota Operator Documentation.

> On Jan. 9, 2016, 4:09 a.m., Guangya Liu wrote: > > docs/quota.md, line 70 > > > > > > s/to even/even ? > > Joerg Schad wrote: > changed it to 'event to ignore' > > Guangya Liu wrote: > I think you meant "e

Re: Review Request 42040: Added Quota Operator Documentation.

> On Jan. 9, 2016, 4:09 a.m., Guangya Liu wrote: > > docs/quota.md, lines 306-310 > > > > > > 1) what about adding "update Quota" here and remove it from L189 > > 2) no Quota Limit but only guarantee > > > >

Re: Review Request 42040: Added Quota Operator Documentation.

> On Jan. 9, 2016, 4:09 a.m., Guangya Liu wrote: > > docs/quota.md, lines 33-34 > > > > > > But we did have plan to introduce maximal limit in MESOS-3858 , can we > > calarify here? > > Joerg Schad wrote: > We d

Re: Review Request 42040: Added Quota Operator Documentation.

> On Jan. 9, 2016, 4:09 a.m., Guangya Liu wrote: > > docs/quota.md, line 175 > > > > > > Do we need to mention that the 80% is not configurable now? > > Joerg Schad wrote: > I would just add a note once it is co

Re: Review Request 42040: Added Quota Operator Documentation.

> On 一月 9, 2016, 4:09 a.m., Guangya Liu wrote: > > docs/quota.md, lines 306-310 > > > > > > 1) what about adding "update Quota" here and remove it from L189 > > 2) no Quota Limit but only guarantee > > > >

Re: Review Request 42040: Added Quota Operator Documentation.

> On Jan. 7, 2016, 11:55 p.m., Neil Conway wrote: > > docs/quota.md, line 61 > > > > > > These kinds of implementation details belong at the bottom of the > > document, I think -- it is more important to tell the use

Re: Review Request 42040: Added Quota Operator Documentation.

> On Jan. 9, 2016, 4:09 a.m., Guangya Liu wrote: > > docs/quota.md, lines 306-310 > > > > > > 1) what about adding "update Quota" here and remove it from L189 > > 2) no Quota Limit but only guarantee > > > >

Re: Review Request 42040: Added Quota Operator Documentation.

> On Jan. 9, 2016, 4:09 a.m., Guangya Liu wrote: > > docs/quota.md, lines 33-34 > > > > > > But we did have plan to introduce maximal limit in MESOS-3858 , can we > > calarify here? We discussed that part, but agree

Re: Review Request 42040: Added Quota Operator Documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42040/#review113601 --- docs/quota.md (line 20)

Re: Review Request 42040: Added Quota Operator Documentation.

> On Jan. 7, 2016, 11:55 p.m., Neil Conway wrote: > > docs/quota.md, line 226 > > > > > > Fix this link -- probably just link to roles.md. Although we don't > > really call the feature "implicit roles" in the user-f

Re: Review Request 42040: Added Quota Operator Documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42040/#review113496 --- docs/home.md (line 42)

Re: Review Request 42040: Added Quota Operator Documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42040/#review113455 --- Patch looks great! Reviews applied: [42040] Passed command: expor

Re: Review Request 42040: Added Quota Operator Documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42040/ --- (Updated Jan. 8, 2016, 10:26 a.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 42040: Added Quota Operator Documentation.

> On Jan. 7, 2016, 11:55 p.m., Neil Conway wrote: > > Can we link this page from `home.md`? > > > > Overall: looks great! Only major feedback is to move the implementation > > details down to the bottom (or remove them), and refactor things slightly > > so that any user-visible behavior (e.g.,

Re: Review Request 42040: Added Quota Operator Documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42040/#review113402 --- Patch looks great! Reviews applied: [42040] Passed command: expor

Re: Review Request 42040: Added Quota Operator Documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42040/#review113358 --- Can we link this page from `home.md`? Overall: looks great! Only m

Review Request 42040: Added Quota Operator Documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42040/ --- Review request for mesos, Alexander Rukletsov, Bernd Mathiske, Joris Van Remoort