---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42053/
---
(Updated Jan. 12, 2016, 10:05 p.m.)
Review request for mesos and Ben Mahler.
> On Jan. 12, 2016, 1:38 a.m., Ben Mahler wrote:
> > Looks great, thanks! Just a few trivial comments below, and we can commit
> > this once the unit test is in place.
I've addressed the two issues below and pushed a new patch. Patch for unit
test forthcoming.
- Kevin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42053/
---
(Updated Jan. 12, 2016, 6:37 p.m.)
Review request for mesos and Ben Mahler.
B
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42053/
---
(Updated Jan. 12, 2016, 6:36 p.m.)
Review request for mesos and Ben Mahler.
C
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42053/#review113944
---
Patch looks great!
Reviews applied: [42053]
Passed command: expor
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42053/#review113896
---
Looks great, thanks! Just a few trivial comments below, and we can
- Kevin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42053/#review113428
---
On Jan. 11, 2016, 9:39 p.m., Kevin Klues wrote:
>
> ---
- Kevin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42053/#review113428
---
On Jan. 11, 2016, 9:39 p.m., Kevin Klues wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42053/
---
(Updated Jan. 11, 2016, 9:39 p.m.)
Review request for mesos and Ben Mahler.
B
> On Jan. 8, 2016, 7:16 a.m., Anand Mazumdar wrote:
> > LGTM. Two minor issues:
> >
> > 1. May be we can escape without passing the `Master` pointer around?
> > 2. Would be great to have a test to go with this?
I am submitting the test as a separate patch.
> On Jan. 8, 2016, 7:16 a.m., Anand
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42053/#review113547
---
Patch looks great!
Reviews applied: [42053]
Passed command: expor
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42053/
---
(Updated Jan. 8, 2016, 5:47 p.m.)
Review request for mesos and Ben Mahler.
Ch
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42053/#review113428
---
LGTM. Two minor issues:
1. May be we can escape without passing th
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42053/#review113418
---
Bad patch!
Reviews applied: [42053]
Failed command: ./support/app
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42053/#review113391
---
Overall looks good!
Is it worth adding a unit test for this, I won
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42053/
---
Review request for mesos and Ben Mahler.
Bugs: MESOS-3307
https://issues.ap
16 matches
Mail list logo
