Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers.

2016-01-12 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42086/#review114153 --- src/master/master.cpp (line 3048)

Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers.

2016-01-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42086/#review114133 --- Patch looks great! Reviews applied: [42092, 42086] Passed command

Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers.

2016-01-12 Thread Joseph Wu
> On Jan. 12, 2016, 6:43 a.m., Benjamin Bannier wrote: > > src/master/master.cpp, line 3084 > > > > > > Since there's a clean separation among offers and inverse offers, it > > seems we could begin logging unknown

Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers.

2016-01-12 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42086/ --- (Updated Jan. 12, 2016, 2:20 p.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers.

2016-01-12 Thread Joseph Wu
> On Jan. 12, 2016, 6:43 a.m., Benjamin Bannier wrote: > > src/master/master.cpp, line 3084 > > > > > > Since there's a clean separation among offers and inverse offers, it > > seems we could begin logging unknown

Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers.

2016-01-12 Thread Benjamin Bannier
> On Jan. 12, 2016, 3:43 p.m., Benjamin Bannier wrote: > > src/master/master.cpp, line 3084 > > > > > > Since there's a clean separation among offers and inverse offers, it > > seems we could begin logging unknown

Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers.

2016-01-12 Thread Joseph Wu
> On Jan. 9, 2016, 1:02 a.m., Klaus Ma wrote: > > src/master/master.cpp, line 3078 > > > > > > If both `offerError.isSome()` and `inverseOfferError.isSome()`, should > > we return `Error()`? > > Joseph Wu wrote: >

Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers.

2016-01-12 Thread Joseph Wu
> On Jan. 12, 2016, 6:43 a.m., Benjamin Bannier wrote: > > src/master/master.cpp, line 3084 > > > > > > Since there's a clean separation among offers and inverse offers, it > > seems we could begin logging unknown

Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers.

2016-01-12 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42086/#review113991 --- src/master/master.cpp (line 3072)

Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers.

2016-01-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42086/#review113952 --- Patch looks great! Reviews applied: [42092, 42086] Passed command

Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers.

2016-01-11 Thread Klaus Ma
> On Jan. 9, 2016, 5:02 p.m., Klaus Ma wrote: > > src/master/master.cpp, line 3078 > > > > > > If both `offerError.isSome()` and `inverseOfferError.isSome()`, should > > we return `Error()`? > > Joseph Wu wrote: >

Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers.

2016-01-11 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42086/ --- (Updated Jan. 11, 2016, 1:31 p.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers.

2016-01-11 Thread Joseph Wu
> On Jan. 8, 2016, 7:13 p.m., Guangya Liu wrote: > > src/master/validation.cpp, lines 678-709 > > > > > > I saw that there is no test cases for offer validation, do you want to > > add inverseOffer test here? I thi

Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers.

2016-01-11 Thread Joseph Wu
> On Jan. 9, 2016, 1:02 a.m., Klaus Ma wrote: > > src/master/master.cpp, line 3078 > > > > > > If both `offerError.isSome()` and `inverseOfferError.isSome()`, should > > we return `Error()`? What do you mean? (Th

Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers.

2016-01-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42086/#review113672 --- Patch looks great! Reviews applied: [42092, 42086] Passed command

Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers.

2016-01-09 Thread Klaus Ma
> On Jan. 9, 2016, 8:09 a.m., Klaus Ma wrote: > > src/master/validation.cpp, line 597 > > > > > > There're several similar code: > > if (condition) { > > return Error(); > > } > >

Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers.

2016-01-09 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42086/#review113610 --- src/master/master.cpp (line 3066)

Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers.

2016-01-08 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42086/#review113597 --- src/master/master.cpp (lines 3054 - 3059)

Re: Review Request 42086: Updated and refactored Master::accept for Offers with InverseOffers.

2016-01-08 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42086/ --- (Updated Jan. 8, 2016, 5:58 p.m.) Review request for mesos, Ben Mahler, Artem H