Re: Review Request 42603: Added an http::Authenticator factory.

2016-01-25 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42603/ --- (Updated Jan. 25, 2016, 1:44 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 42603: Added an http::Authenticator factory.

2016-01-27 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42603/#review116582 --- include/mesos/authentication/http/basic_authenticator_factory.hpp

Re: Review Request 42603: Added an http::Authenticator factory.

2016-01-27 Thread Alexander Rojas
> On Jan. 27, 2016, 3:29 p.m., Jan Schlicht wrote: > > src/authentication/http/authenticator.cpp, lines 58-60 > > > > > > If multiple HTTP authenticators are not supported, why is > > `authenticators` supposed to be

Re: Review Request 42603: Added an http::Authenticator factory.

2016-01-27 Thread Alexander Rojas
> On Jan. 27, 2016, 3:29 p.m., Jan Schlicht wrote: > > src/master/master.cpp, line 535 > > > > > > Good that you check for `NULL` here! > > > > The error message is fairly generic though. It would be great i

Re: Review Request 42603: Added an http::Authenticator factory.

2016-01-27 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42603/ --- (Updated Jan. 27, 2016, 4:38 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 42603: Added an http::Authenticator factory.

2016-01-27 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42603/#review116591 --- Could you separate changes due to `http::Authenticator` and for up

Re: Review Request 42603: Added an http::Authenticator factory.

2016-01-27 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42603/ --- (Updated Jan. 27, 2016, 10:22 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 42603: Added an http::Authenticator factory.

2016-01-27 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42603/#review116641 --- Fix it, then Ship it! include/mesos/authentication/http/basic_