Re: Review Request 42861: Ensure two Mount Disk resources do not have the same root path.

2016-09-07 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42861/#review148062 --- As Greg said some tests would be great. Then we can ship this. s

Re: Review Request 42861: Ensure two Mount Disk resources do not have the same root path.

2016-09-06 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42861/#review147938 --- Thanks Haosdent! Looks good. Could you also add a test for this?

Re: Review Request 42861: Ensure two Mount Disk resources do not have the same root path.

2016-04-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42861/#review126630 --- Patch looks great! Reviews applied: [42860, 42861] Passed comman

Re: Review Request 42861: Ensure two Mount Disk resources do not have the same root path.

2016-04-01 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42861/ --- (Updated April 1, 2016, 4:43 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 42861: Ensure two Mount Disk resources do not have the same root path.

2016-03-29 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42861/ --- (Updated March 29, 2016, 5:33 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 42861: Ensure two Mount Disk resources do not have the same root path.

2016-03-29 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42861/ --- (Updated March 29, 2016, 5:29 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 42861: Ensure two Mount Disk resources do not have the same root path.

2016-03-29 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42861/ --- (Updated March 29, 2016, 8:56 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 42861: Ensure two Mount Disk resources do not have the same root path.

2016-03-28 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42861/#review125802 --- It would be good to have a unit test for the end-to-end behavior (

Re: Review Request 42861: Ensure two Mount Disk resources do not have the same root path.

2016-03-28 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42861/ --- (Updated March 29, 2016, 2:30 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 42861: Ensure two Mount Disk resources do not have the same root path.

2016-03-21 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42861/#review124576 --- src/slave/slave.cpp (line 430)

Re: Review Request 42861: Ensure two Mount Disk resources do not have the same root path.

2016-01-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42861/#review116731 --- Patch looks great! Reviews applied: [42860, 42861] Passed comman

Re: Review Request 42861: Ensure two Mount Disk resources do not have the same root path.

2016-01-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42861/ --- (Updated Jan. 28, 2016, 2:12 a.m.) Review request for mesos, Jie Yu and Joris V

Re: Review Request 42861: Ensure two Mount Disk resources do not have the same root path.

2016-01-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42861/ --- (Updated Jan. 27, 2016, 6:36 p.m.) Review request for mesos, Jie Yu and Joris V

Review Request 42861: Ensure two Mount Disk resources do not have the same root path.

2016-01-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42861/ --- Review request for mesos, Jie Yu and Joris Van Remoortere. Bugs: MESOS-4521