Re: Review Request 42957: Added remove() calls to process::Help.

2016-02-04 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42957/#review117958 --- Ship it! Ship It! - Ben Mahler On Feb. 5, 2016, 3:20 a.m., K

Re: Review Request 42957: Added remove() calls to process::Help.

2016-02-04 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42957/ --- (Updated Feb. 5, 2016, 3:20 a.m.) Review request for mesos, Ben Mahler, Greg Ma

Re: Review Request 42957: Added remove() calls to process::Help.

2016-02-04 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42957/ --- (Updated Feb. 4, 2016, 10:05 p.m.) Review request for mesos, Ben Mahler, Greg M

Re: Review Request 42957: Added remove() calls to process::Help.

2016-02-04 Thread Kevin Klues
> On Feb. 4, 2016, 9:12 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/src/help.cpp, lines 123-129 > > > > > > Is this equivalent to just `return helps.erase(id)`? Yes, these are equivalent. Updated. > On F

Re: Review Request 42957: Added remove() calls to process::Help.

2016-02-04 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42957/#review117882 --- 3rdparty/libprocess/src/help.cpp (line 107)

Re: Review Request 42957: Added remove() calls to process::Help.

2016-02-04 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42957/ --- (Updated Feb. 4, 2016, 8:30 p.m.) Review request for mesos, Ben Mahler, Greg Ma

Re: Review Request 42957: Added remove() calls to process::Help.

2016-01-29 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42957/ --- (Updated Jan. 29, 2016, 10:30 p.m.) Review request for mesos, Ben Mahler, Greg

Review Request 42957: Added remove() calls to process::Help.

2016-01-29 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42957/ --- Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway. Bugs: MESOS-4