Re: Review Request 42992: Support sharing of resources through reference counting of resources.

2016-02-13 Thread Anindya Sinha
> On Feb. 13, 2016, 12:57 a.m., Greg Mann wrote: > > include/mesos/resources.hpp, line 222 > > > > > > I might recommend renaming this method, due to the ubiquitous `get()` > > method of the `Future` and `Option`

Re: Review Request 42992: Support sharing of resources through reference counting of resources.

2016-02-13 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42992/ --- (Updated Feb. 14, 2016, 6:24 a.m.) Review request for mesos and Adam B.

Re: Review Request 42992: Support sharing of resources through reference counting of resources.

2016-02-12 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42992/#review119090 --- include/mesos/mesos.proto (line 688)

Re: Review Request 42992: Support sharing of resources through reference counting of resources.

2016-02-11 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42992/#review118865 --- src/common/resources.cpp (lines 202 - 205)

Re: Review Request 42992: Support sharing of resources through reference counting of resources.

2016-02-11 Thread Anindya Sinha
> On Feb. 11, 2016, 3:14 p.m., Guangya Liu wrote: > > src/common/resources.cpp, lines 202-205 > > > > > > Does this require that the num_consumers should be same? No. This just checks that we are comparing 2

Re: Review Request 42992: Support sharing of resources through reference counting of resources.

2016-02-05 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42992/ --- (Updated Feb. 5, 2016, 10:57 p.m.) Review request for mesos and Adam B.

Re: Review Request 42992: Support sharing of resources through reference counting of resources.

2016-02-01 Thread Anindya Sinha
> On Jan. 30, 2016, 4:02 a.m., Guangya Liu wrote: > > src/common/resources.cpp, line 899 > > > > > > Do we also need to check contain here? > > > > I think that the unsharable should be failed if the

Re: Review Request 42992: Support sharing of resources through reference counting of resources.

2016-02-01 Thread Anindya Sinha
> On Feb. 1, 2016, 3:46 a.m., Guangya Liu wrote: > > src/master/master.cpp, lines 5444-5445 > > > > > > move this comments to 5452 To avoid rebase issues, I will fix this as a part of

Re: Review Request 42992: Support sharing of resources through reference counting of resources.

2016-02-01 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42992/ --- (Updated Feb. 2, 2016, 12:36 a.m.) Review request for mesos and Adam B.