Re: Review Request 43269: MasterContender/MasterDetector loadable as modules.

2016-07-09 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43269/#review141549 --- Closing this review due to inactivity. Please see our [guidelines

Re: Review Request 43269: MasterContender/MasterDetector loadable as modules.

2016-02-19 Thread Joseph Wu
> On Feb. 18, 2016, 12:56 p.m., Joseph Wu wrote: > > Can you split up this patch into the following groups? (Its ok to run the > > tests at the end of a review chain, just add a note in the "Testing Done" > > section.) > > > > * Interfaces for the new module. > > * Modularization boilerplate

Re: Review Request 43269: MasterContender/MasterDetector loadable as modules.

2016-02-19 Thread Mark Cavage
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43269/ --- (Updated Feb. 19, 2016, 6:52 p.m.) Review request for mesos and Benjamin Hindma

Re: Review Request 43269: MasterContender/MasterDetector loadable as modules.

2016-02-19 Thread Mark Cavage
> On Feb. 18, 2016, 8:56 p.m., Joseph Wu wrote: > > Can you split up this patch into the following groups? (Its ok to run the > > tests at the end of a review chain, just add a note in the "Testing Done" > > section.) > > > > * Interfaces for the new module. > > * Modularization boilerplate (

Re: Review Request 43269: MasterContender/MasterDetector loadable as modules.

2016-02-18 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43269/#review119715 --- Can you split up this patch into the following groups? (Its ok to

Re: Review Request 43269: MasterContender/MasterDetector loadable as modules.

2016-02-18 Thread Mark Cavage
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43269/ --- (Updated Feb. 18, 2016, 7:51 p.m.) Review request for mesos and Benjamin Hindma

Re: Review Request 43269: MasterContender/MasterDetector loadable as modules.

2016-02-17 Thread Mark Cavage
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43269/ --- (Updated Feb. 17, 2016, 10:10 p.m.) Review request for mesos and Benjamin Hindm

Re: Review Request 43269: MasterContender/MasterDetector loadable as modules.

2016-02-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43269/#review119500 --- Bad patch! Reviews applied: [43269] Failed command: ./support/ap

Re: Review Request 43269: MasterContender/MasterDetector loadable as modules.

2016-02-17 Thread Mark Cavage
> On Feb. 15, 2016, 6:25 p.m., Benjamin Hindman wrote: > > src/master/contender.cpp, line 80 > > > > > > Why the removal of the `Option`? Conveying the information via an empty > > string is far less explicit and not

Re: Review Request 43269: MasterContender/MasterDetector loadable as modules.

2016-02-17 Thread Mark Cavage
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43269/ --- (Updated Feb. 17, 2016, 4:56 p.m.) Review request for mesos and Benjamin Hindma

Re: Review Request 43269: MasterContender/MasterDetector loadable as modules.

2016-02-15 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43269/#review119232 --- include/mesos/master/contender.hpp (lines 17 - 18)

Re: Review Request 43269: MasterContender/MasterDetector loadable as modules.

2016-02-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43269/#review118154 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Review Request 43269: MasterContender/MasterDetector loadable as modules.

2016-02-05 Thread Mark Cavage
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43269/ --- Review request for mesos. Bugs: MESOS-4610 https://issues.apache.org/jira/b