Re: Review Request 43336: Introduced Appc image fetcher.

2016-02-17 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43336/#review119522 --- Ship it! Ship It! - Jie Yu On Feb. 16, 2016, 11:36 p.m., Joj

Re: Review Request 43336: Introduced Appc image fetcher.

2016-02-16 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43336/ --- (Updated Feb. 16, 2016, 11:36 p.m.) Review request for mesos and Jie Yu. Chan

Re: Review Request 43336: Introduced Appc image fetcher.

2016-02-13 Thread Jojy Varghese
> On Feb. 13, 2016, 1:58 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/appc/fetcher.cpp, line 89 > > > > > > No need for 'doFetchImage' since only this function is using it. Can > > you just inlin

Re: Review Request 43336: Introduced Appc image fetcher.

2016-02-13 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43336/#review119147 --- I think this review request should be linked to https://issues.ap

Re: Review Request 43336: Introduced Appc image fetcher.

2016-02-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43336/#review119133 --- Patch looks great! Reviews applied: [41958, 41959, 43546, 43336]

Re: Review Request 43336: Introduced Appc image fetcher.

2016-02-12 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43336/#review119123 --- src/slave/containerizer/mesos/provisioner/appc/fetcher.hpp (line

Re: Review Request 43336: Introduced Appc image fetcher.

2016-02-12 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43336/ --- (Updated Feb. 13, 2016, 1:43 a.m.) Review request for mesos and Jie Yu. Chang

Re: Review Request 43336: Introduced Appc image fetcher.

2016-02-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43336/#review119112 --- Patch looks great! Reviews applied: [41958, 41959, 43546, 43336]

Re: Review Request 43336: Introduced Appc image fetcher.

2016-02-12 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43336/ --- (Updated Feb. 12, 2016, 9:46 p.m.) Review request for mesos and Jie Yu. Chang

Re: Review Request 43336: Introduced Appc image fetcher.

2016-02-11 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43336/#review118947 --- First pass. Will do a more detailed path tomorrow. Thanks Jojy!

Re: Review Request 43336: Introduced Appc image fetcher.

2016-02-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43336/#review118900 --- Bad patch! Reviews applied: [41958, 41959, 42156, 42157, 43127, 4

Re: Review Request 43336: Introduced Appc image fetcher.

2016-02-11 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43336/ --- (Updated Feb. 11, 2016, 5:52 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 43336: Introduced Appc image fetcher.

2016-02-11 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43336/ --- (Updated Feb. 11, 2016, 5:28 p.m.) Review request for mesos and Jie Yu. Chang

Re: Review Request 43336: Introduced Appc image fetcher.

2016-02-09 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43336/#review118430 --- This is a partial review. I scanned the entire patch and realized

Re: Review Request 43336: Introduced Appc image fetcher.

2016-02-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43336/#review118288 --- Patch looks great! Reviews applied: [41958, 41959, 42156, 42157,

Review Request 43336: Introduced Appc image fetcher.

2016-02-08 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43336/ --- Review request for mesos and Jie Yu. Repository: mesos Description --- A