Review Request 43908: Stout:[2/2] Added significant test coverage of `os::rmdir`.

2016-02-25 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43908/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris V

Re: Review Request 43908: Stout:[2/2] Added significant test coverage of `os::rmdir`.

2016-02-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43908/#review120825 --- Bad patch! Reviews applied: [43908, 43907, 43906] Failed command

Re: Review Request 43908: Stout:[2/2] Added significant test coverage of `os::rmdir`.

2016-02-26 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43908/#review120966 --- Ship it! Ship It! - Alex Naparu On Feb. 25, 2016, 7:40 p.m.,

Re: Review Request 43908: Stout:[2/2] Added significant test coverage of `os::rmdir`.

2016-03-01 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43908/#review121532 --- 3rdparty/libprocess/3rdparty/stout/Makefile.am (line 48)

Re: Review Request 43908: Stout:[2/2] Added significant test coverage of `os::rmdir`.

2016-03-01 Thread Alex Clemmer
> On March 1, 2016, 11:21 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/Makefile.am, line 48 > > > > > > style I'd just like to clarify that I made this line up in `git diff` because it was

Re: Review Request 43908: Stout:[2/2] Added significant test coverage of `os::rmdir`.

2016-03-01 Thread Alex Clemmer
> On March 1, 2016, 11:21 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp, line 172 > > > > > > What is this? THe remnants of a merge of two commits, unfortunately.

Re: Review Request 43908: Stout:[2/2] Added significant test coverage of `os::rmdir`.

2016-03-01 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43908/ --- (Updated March 2, 2016, 4 a.m.) Review request for mesos, Alex Naparu, Daniel P

Re: Review Request 43908: Stout:[2/2] Added significant test coverage of `os::rmdir`.

2016-03-01 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43908/#review121604 --- Ship it! Ship It! - Joris Van Remoortere On March 2, 2016, 4