Re: Review Request 43956: Created base docker image for test suite.

2016-03-11 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43956/ --- (Updated March 11, 2016, 4:15 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 43956: Created base docker image for test suite.

2016-03-11 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43956/#review123173 --- src/tests/containerizer/docker_archive.hpp (line 169)

Re: Review Request 43956: Created base docker image for test suite.

2016-03-11 Thread Gilbert Song
> On March 10, 2016, 6:22 p.m., Jie Yu wrote: > > I think we should not use `Option` here, because in a docker manifest, it does not exist None case. If any field does not exist, it should be JSON::null. Entrypoint/cmd should be either JSON::null or a JSON::array `["a", "b", ...]`. So we sh

Re: Review Request 43956: Created base docker image for test suite.

2016-03-10 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43956/#review123068 --- Fix it, then Ship it! src/tests/containerizer/docker_archive.h

Re: Review Request 43956: Created base docker image for test suite.

2016-03-10 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43956/ --- (Updated March 10, 2016, 3:37 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 43956: Created base docker image for test suite.

2016-03-10 Thread Gilbert Song
> On March 8, 2016, 6:57 p.m., Guangya Liu wrote: > > src/tests/containerizer/docker_archive.hpp, lines 70-75 > > > > > > Two layer will not work with bind backend, does it make sense to enable > > `create` can speci

Re: Review Request 43956: Created base docker image for test suite.

2016-03-10 Thread Gilbert Song
> On March 9, 2016, 2:59 p.m., Jie Yu wrote: > > Can you also update cmakelist? cmakelist not supports test build yet. - Gilbert --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43956/#review1