Re: Review Request 44029: Fetcher::basename should ignore query strings and fragments.

2016-03-01 Thread James Peach
> On Feb. 26, 2016, 1:40 p.m., Bernd Mathiske wrote: > > There is a more elaborate solution to this problem > > (https://reviews.apache.org/r/40054), but it requires a lot of code to > > implement URL parsing. Until we finalize that, I think the patch at hand > > gets the most urgent job done.

Re: Review Request 44029: Fetcher::basename should ignore query strings and fragments.

2016-03-01 Thread Bernd Mathiske
> On Feb. 26, 2016, 5:40 a.m., Bernd Mathiske wrote: > > There is a more elaborate solution to this problem > > (https://reviews.apache.org/r/40054), but it requires a lot of code to > > implement URL parsing. Until we finalize that, I think the patch at hand > > gets the most urgent job done.

Re: Review Request 44029: Fetcher::basename should ignore query strings and fragments.

2016-02-26 Thread Jiang Yan Xu
> On Feb. 26, 2016, 5:40 a.m., Bernd Mathiske wrote: > > There is a more elaborate solution to this problem > > (https://reviews.apache.org/r/40054), but it requires a lot of code to > > implement URL parsing. Until we finalize that, I think the patch at hand > > gets the most urgent job done.

Re: Review Request 44029: Fetcher::basename should ignore query strings and fragments.

2016-02-26 Thread James Peach
> On Feb. 26, 2016, 1:40 p.m., Bernd Mathiske wrote: > > There is a more elaborate solution to this problem > > (https://reviews.apache.org/r/40054), but it requires a lot of code to > > implement URL parsing. Until we finalize that, I think the patch at hand > > gets the most urgent job done.

Re: Review Request 44029: Fetcher::basename should ignore query strings and fragments.

2016-02-26 Thread Jiang Yan Xu
> On Feb. 26, 2016, 5:40 a.m., Bernd Mathiske wrote: > > There is a more elaborate solution to this problem > > (https://reviews.apache.org/r/40054), but it requires a lot of code to > > implement URL parsing. Until we finalize that, I think the patch at hand > > gets the most urgent job done.

Re: Review Request 44029: Fetcher::basename should ignore query strings and fragments.

2016-02-26 Thread Jiang Yan Xu
> On Feb. 26, 2016, 5:40 a.m., Bernd Mathiske wrote: > > There is a more elaborate solution to this problem > > (https://reviews.apache.org/r/40054), but it requires a lot of code to > > implement URL parsing. Until we finalize that, I think the patch at hand > > gets the most urgent job done.

Re: Review Request 44029: Fetcher::basename should ignore query strings and fragments.

2016-02-26 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44029/#review120864 --- Ship it! There is a more elaborate solution to this problem (h

Re: Review Request 44029: Fetcher::basename should ignore query strings and fragments.

2016-02-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44029/#review120812 --- Patch looks great! Reviews applied: [44029] Passed command: expo

Review Request 44029: Fetcher::basename should ignore query strings and fragments.

2016-02-25 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44029/ --- Review request for mesos, Bernd Mathiske, Jie Yu, and Jiang Yan Xu. Bugs: MESOS