Re: Review Request 44138: Windows:[1/2] Lifted socket API into Stout.

2016-03-11 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44138/ --- (Updated March 12, 2016, 2:02 a.m.) Review request for mesos, Alex Naparu, Dani

Re: Review Request 44138: Windows:[1/2] Lifted socket API into Stout.

2016-03-14 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44138/ --- (Updated March 14, 2016, 3:45 p.m.) Review request for mesos, Alex Naparu, Dani

Re: Review Request 44138: Windows:[1/2] Lifted socket API into Stout.

2016-03-19 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44138/ --- (Updated March 17, 2016, 6:48 p.m.) Review request for mesos, Alex Naparu, Dani

Re: Review Request 44138: Windows:[1/2] Lifted socket API into Stout.

2016-03-21 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44138/#review124122 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/socket.

Re: Review Request 44138: Windows:[1/2] Lifted socket API into Stout.

2016-03-21 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44138/ --- (Updated March 21, 2016, 10:53 p.m.) Review request for mesos, Alex Naparu, Dan

Re: Review Request 44138: Windows:[1/2] Lifted socket API into Stout.

2016-03-23 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44138/#review124782 --- Fix it, then Ship it! 3rdparty/libprocess/3rdparty/stout/inclu

Re: Review Request 44138: Windows:[1/2] Lifted socket API into Stout.

2016-03-23 Thread Daniel Pravat
> On March 21, 2016, 9:02 a.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/socket.hpp, lines > > 28-36 > > > > > > Let's namespace these with `socket` since both functio

Re: Review Request 44138: Windows:[1/2] Lifted socket API into Stout.

2016-03-23 Thread Daniel Pravat
> On March 23, 2016, 12:40 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/socket.hpp, line > > 35 > > > > > > Should `EINPROGRESS` be in here? > > would a retry

Re: Review Request 44138: Windows:[1/2] Lifted socket API into Stout.

2016-03-23 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44138/ --- (Updated March 23, 2016, 3:59 p.m.) Review request for mesos, Alex Naparu, Dani

Re: Review Request 44138: Windows:[1/2] Lifted socket API into Stout.

2016-03-23 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44138/ --- (Updated March 23, 2016, 4:09 p.m.) Review request for mesos, Alex Naparu, Dani

Re: Review Request 44138: Windows:[1/2] Lifted socket API into Stout.

2016-03-23 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44138/ --- (Updated March 23, 2016, 8:47 p.m.) Review request for mesos, Alex Naparu, Dani

Re: Review Request 44138: Windows:[1/2] Lifted socket API into Stout.

2016-03-23 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44138/ --- (Updated March 24, 2016, 3:17 a.m.) Review request for mesos, Alex Naparu, Dani

Re: Review Request 44138: Windows:[1/2] Lifted socket API into Stout.

2016-03-23 Thread Daniel Pravat
> On March 23, 2016, 12:40 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/socket.hpp, line > > 35 > > > > > > Should `EINPROGRESS` be in here? > > would a retry