Re: Review Request 44286: Unified/Added Future checks for http methods in tests.

2016-03-07 Thread Joerg Schad
> On March 7, 2016, 9:28 a.m., Adam B wrote: > > src/tests/fault_tolerance_tests.cpp, lines 230-233 > > > > > > Should we also `AWAIT_EXPECT_RESPONSE_HEADER_EQ(APPLICATION_JSON, > > "Content-Type", masterState);`? >

Re: Review Request 44286: Unified/Added Future checks for http methods in tests.

2016-03-07 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44286/#review122274 --- Fix it, then Ship it! Looks good. Just wondering if we should a

Re: Review Request 44286: Unified/Added Future checks for http methods in tests.

2016-03-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44286/#review121742 --- Patch looks great! Reviews applied: [44286] Passed command: expo

Re: Review Request 44286: Unified/Added Future checks for http methods in tests.

2016-03-02 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44286/ --- (Updated March 2, 2016, 8:53 p.m.) Review request for mesos, Adam B and Alexand