Re: Review Request 44288: Changed MasterDetector/Contender namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/#review127498 --- Ship it! Ship It! - Kapil Arya On April 6, 2016, 12:02

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/ --- (Updated April 6, 2016, 4:02 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/ --- (Updated April 6, 2016, 3:13 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/#review126359 --- - Kapil Arya On March 23, 2016, 7:04 p.m., Anurag Singh wrote:

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/#review125919 --- include/mesos/v1/scheduler.hpp (lines 31 - 33)

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/ --- (Updated March 21, 2016, 3:43 p.m.) Review request for mesos and Benjamin

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/#review124274 --- Looks like the recent test refactor (mine) created more work for

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/ --- (Updated March 18, 2016, 12:29 a.m.) Review request for mesos and Benjamin

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

> On March 18, 2016, 9:03 p.m., Joseph Wu wrote: > > src/master/contender.cpp, line 91 > > > > > > Another spacing change seems to have snuck in. Apologies ... I forgot to add expandtab in my vimrc. Fixing it. -

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/ --- (Updated March 15, 2016, 11:01 p.m.) Review request for mesos and Benjamin

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/ --- (Updated March 15, 2016, 6:17 a.m.) Review request for mesos and Benjamin

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/ --- (Updated March 14, 2016, 11:49 p.m.) Review request for mesos and Benjamin

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/#review123196 --- Mostly nits here. include/mesos/v1/scheduler.hpp (line 39)

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

> On March 3, 2016, 10:15 p.m., Joseph Wu wrote: > > src/master/contender.hpp, lines 17-18 > > > > > > This whole file seems like a pretty substantial change. I'd recommend > > pulling it out into a separate review

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/ --- (Updated March 10, 2016, 11:45 p.m.) Review request for mesos and Benjamin

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/ --- (Updated March 10, 2016, 7:34 p.m.) Review request for mesos and Benjamin

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

> On March 3, 2016, 10:15 p.m., Joseph Wu wrote: > > src/master/contender.hpp, lines 17-18 > > > > > > This whole file seems like a pretty substantial change. I'd recommend > > pulling it out into a separate review

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

> On March 3, 2016, 10:15 p.m., Joseph Wu wrote: > > include/mesos/scheduler.hpp, lines 44-49 > > > > > > A forward declaration isn't required anymore. You can just include the > > header(s) from the previous

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/ --- (Updated March 9, 2016, 1:35 a.m.) Review request for mesos and Benjamin

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

> On March 3, 2016, 2:15 p.m., Joseph Wu wrote: > > src/master/contender.hpp, lines 17-18 > > > > > > This whole file seems like a pretty substantial change. I'd recommend > > pulling it out into a separate review

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

> On March 3, 2016, 10:15 p.m., Joseph Wu wrote: > > src/master/contender.hpp, lines 17-18 > > > > > > This whole file seems like a pretty substantial change. I'd recommend > > pulling it out into a separate review

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

> On March 3, 2016, 2:15 p.m., Joseph Wu wrote: > > src/master/main.cpp, line 61 > > > > > > What about this header? > > Anurag Singh wrote: > Do you mean why is this header not ""? It's > different from - it

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

> On March 3, 2016, 10:15 p.m., Joseph Wu wrote: > > src/master/main.cpp, line 61 > > > > > > What about this header? > > Anurag Singh wrote: > Do you mean why is this header not ""? It's > different from - it

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

> On March 3, 2016, 2:15 p.m., Joseph Wu wrote: > > src/master/contender.hpp, lines 17-18 > > > > > > This whole file seems like a pretty substantial change. I'd recommend > > pulling it out into a separate review

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

> On March 3, 2016, 10:15 p.m., Joseph Wu wrote: > > src/master/contender.hpp, lines 17-18 > > > > > > This whole file seems like a pretty substantial change. I'd recommend > > pulling it out into a separate review

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

> On March 3, 2016, 10:15 p.m., Joseph Wu wrote: > > src/master/contender.hpp, lines 17-18 > > > > > > This whole file seems like a pretty substantial change. I'd recommend > > pulling it out into a separate review

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

> On March 3, 2016, 10:15 p.m., Joseph Wu wrote: > > src/master/main.cpp, line 61 > > > > > > What about this header? Do you mean why is this header not ""? It's different from - it includes the

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

> On March 3, 2016, 10:15 p.m., Joseph Wu wrote: > > src/master/contender.hpp, lines 17-18 > > > > > > This whole file seems like a pretty substantial change. I'd recommend > > pulling it out into a separate review

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/#review121944 --- Partial review to check for non-namespace-changes:

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/ --- (Updated March 3, 2016, 5:30 p.m.) Review request for mesos and Benjamin

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/ --- (Updated March 2, 2016, 9:30 p.m.) Review request for mesos. Bugs:

Review Request 44288: Changed MasterDetector/Contender namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/ --- Review request for mesos. Repository: mesos Description --- Also