Re: Review Request 44366: Added GPUs as an explicit resource.

2016-03-29 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44366/#review125994 --- Ship it! Went over this with kevin, we'll be making some minor

Re: Review Request 44366: Added GPUs as an explicit resource.

2016-03-14 Thread Kevin Klues
> On March 8, 2016, 10:45 p.m., Vikrama Ditya wrote: > > src/slave/containerizer/containerizer.cpp, line 107 > > > > > > It will be good to comment that --nvidia-gpus flag consists of devices > > numbers as comes

Re: Review Request 44366: Added GPUs as an explicit resource.

2016-03-14 Thread Kevin Klues
> On March 9, 2016, 1:14 a.m., Ben Mahler wrote: > > Could you update the description to reflect the new state of the code? Done. > On March 9, 2016, 1:14 a.m., Ben Mahler wrote: > > src/slave/containerizer/containerizer.cpp, line 96 > >

Re: Review Request 44366: Added GPUs as an explicit resource.

2016-03-14 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44366/ --- (Updated March 14, 2016, 7:39 a.m.) Review request for mesos, Ben Mahler, Rob

Re: Review Request 44366: Added GPUs as an explicit resource.

2016-03-08 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44366/#review122638 --- Could you update the description to reflect the new state of the

Re: Review Request 44366: Added GPUs as an explicit resource.

2016-03-08 Thread Vikrama Ditya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44366/#review122612 --- src/slave/containerizer/containerizer.cpp (line 107)

Re: Review Request 44366: Added GPUs as an explicit resource.

2016-03-05 Thread Kevin Klues
> On March 4, 2016, 12:27 p.m., Klaus Ma wrote: > > OK, got it. I'll wait for more comments and then do a full pass all at once. Thanks! - Kevin --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 44366: Added GPUs as an explicit resource.

2016-03-05 Thread Klaus Ma
> On March 4, 2016, 8:27 p.m., Klaus Ma wrote: > > src/slave/containerizer/containerizer.cpp, line 115 > > > > > > I'd like to say "`--navidia_gpus` must be set when specifying `gpu` > > resources." > > Kevin

Re: Review Request 44366: Added GPUs as an explicit resource.

2016-03-04 Thread Kevin Klues
> On March 4, 2016, 12:27 p.m., Klaus Ma wrote: > > src/slave/containerizer/containerizer.cpp, line 105 > > > > > > `` for --nvidia_gpus; not only this line, please also update them in > > the following comments.

Re: Review Request 44366: Added GPUs as an explicit resource.

2016-03-04 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44366/#review122059 --- src/slave/containerizer/containerizer.cpp (line 105)

Re: Review Request 44366: Added GPUs as an explicit resource.

2016-03-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44366/#review122039 --- Patch looks great! Reviews applied: [44360, 44361, 44363, 44364,

Review Request 44366: Added GPUs as an explicit resource.

2016-03-03 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44366/ --- Review request for mesos, Ben Mahler and Rob Todd. Bugs: MESOS-4865